Configure: Add check for non-existing C(++) source files in build.info#13738
Closed
DDvO wants to merge 1 commit intoopenssl:masterfrom
Closed
Configure: Add check for non-existing C(++) source files in build.info#13738DDvO wants to merge 1 commit intoopenssl:masterfrom
DDvO wants to merge 1 commit intoopenssl:masterfrom
Conversation
This may happen for instance after renaming source files
DDvO
force-pushed
the
Configure_check_sources
branch
from
3566b59 to
b06e863
Compare
Member
|
I'd rather not have this sort of quick hackery in Configure. However, it's a good idea to check consistency a bit better. I've an alternative proposal, which checks all declared sources (including the generators themselves). |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
Configurefail in case abuild.infofile refers to non-existing source file,which may happen by mistake for instance after renaming source files.
If such mistakes are not caught then
makelikely fails later with a (not always intelligible) build dependency error.