Remove TODO(3.0) tags in pkey ctrl functions.#12998
Remove TODO(3.0) tags in pkey ctrl functions.#12998slontis wants to merge 3 commits intoopenssl:masterfrom
Conversation
slontis
added
branch: master
slontis
force-pushed
the
todo_fixes
branch
2 times, most recently
from
21059c0 to
16dd5f9
Compare
|
ping |
|
ping |
1 similar comment
|
ping |
Added a legacy related macro for the pkey controls. Moved dsa & rsa control functions out of XXX_lib.c into XXX_ctrl.c. These are excluded from the fips module. Removed the auto increment past the end of param arrays in multiple places (i.e *p = OSSL_PARAM_construct_end())
|
This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago |
|
This PR is in a state where it requires action by @openssl/committers but the last update was 61 days ago |
|
@slontis Shane, I'm taking this PR over from you. Are you OK with it? |
|
Yes that is fine.. |
|
Hmm, looking at the #13913 makes me think that this PR should be simply closed as the approach taken there is basically reverse of what is done here. There are some useful nits among the changes here that could be applied after #13913 from this PR but otherwise it does not make much sense. So I'll probably postpone this after the #13913 is merged. |
Okie, makes sense. |
|
#13913 is merged. Time to rebase this and see what's left of it, if any... |
I am just going through this and applying remaining useful changes from this to a new PR. Then I'll close this one. |
|
This is now superseded by #14290 |
7 participants
Added a legacy related macro for the pkey controls.
Moved dsa & rsa control functions out of XXX_lib.c into XXX_ctrl.c. These are excluded from the fips module.
Removed the auto increment past the end of param arrays in multiple places (i.e *p = OSSL_PARAM_construct_end())
Checklist