Skip to content

Comments

prov/drbg: cleanup some RAND_DRBG leftovers#12866

Closed
mspncp wants to merge 2 commits intoopenssl:masterfrom
mspncp:pr-cleanup-rand-drbg-leftovers
Closed

prov/drbg: cleanup some RAND_DRBG leftovers#12866
mspncp wants to merge 2 commits intoopenssl:masterfrom
mspncp:pr-cleanup-rand-drbg-leftovers

Conversation

@mspncp
Copy link
Contributor

@mspncp mspncp commented Sep 12, 2020

This pull request adds two commits (listed in reverse chronological order):

commit 040100a
Author: Dr. Matthias St. Pierre [email protected]
Date: Sun Sep 13 00:47:28 2020 +0200

prov/drbg: cleanup some RAND_DRBG leftovers

These are leftovers from the RAND_DRBG removal (#12509).

commit 9dd4813
Author: Dr. Matthias St. Pierre [email protected]
Date: Sun Sep 13 00:17:35 2020 +0200

prov/drbg: fix misspelling of '#ifdef FIPS_MODULE'

@mspncp mspncp added branch: master Applies to master branch approval: review pending This pull request needs review by a committer labels Sep 12, 2020
@mspncp mspncp added this to the 3.0.0 milestone Sep 12, 2020
@mspncp mspncp requested a review from paulidale September 12, 2020 23:52
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Sep 13, 2020
@openssl-machine openssl-machine removed the approval: done This pull request has the required number of approvals label Sep 14, 2020
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@openssl-machine openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label Sep 14, 2020
openssl-machine pushed a commit that referenced this pull request Sep 14, 2020
openssl-machine pushed a commit that referenced this pull request Sep 14, 2020
These are leftovers from the RAND_DRBG removal (#12509).

Reviewed-by: Paul Dale <[email protected]>
(Merged from #12866)
@mspncp
Copy link
Contributor Author

mspncp commented Sep 14, 2020

Merged to master, thank you for the review!

1d30b0a prov/drbg: fix misspelling of '#ifdef FIPS_MODULE'
ec0ce18 EVP: Centralise fetching error reporting

@mspncp mspncp closed this Sep 14, 2020
@mspncp mspncp deleted the pr-cleanup-rand-drbg-leftovers branch September 14, 2020 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants