Fix: ecp_nistz256-armv4.S bad arguments#12854
Closed
HenryNe wants to merge 1 commit intoopenssl:masterfrom
HenryNe:ecp_nistz256-armv4.S-bad-arguments
Closed
Fix: ecp_nistz256-armv4.S bad arguments#12854HenryNe wants to merge 1 commit intoopenssl:masterfrom HenryNe:ecp_nistz256-armv4.S-bad-arguments
HenryNe wants to merge 1 commit intoopenssl:masterfrom
HenryNe:ecp_nistz256-armv4.S-bad-arguments
Conversation
Fix this error: crypto/ec/ecp_nistz256-armv4.S:3853: Error: bad arguments to instruction -- `orr r11,r10' crypto/ec/ecp_nistz256-armv4.S:3854: Error: bad arguments to instruction -- `orr r11,r12' crypto/ec/ecp_nistz256-armv4.S:3855: Error: bad arguments to instruction -- `orrs r11,r14' CLA: trivial Fixes #12848
t8m
added
approval: review pending
Member
|
The only thing preventing me from approving is that I have no access to an armv4 platform to test this on, and this is going to 1.1.1 as well. I'd really like if @bernd-edlinger that wrote and tested the new code originally could chime in. That aside, I agree this would fit the "CLA: trivial" requirements. |
Member
|
I am fairly sure this is OK, although I did not test it either. |
kroeckx
approved these changes
Sep 13, 2020
kroeckx
added
approval: done
Member
|
I agree this is trivial |
Collaborator
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
kroeckx
added
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
Sep 20, 2020
Fix this error: crypto/ec/ecp_nistz256-armv4.S:3853: Error: bad arguments to instruction -- `orr r11,r10' crypto/ec/ecp_nistz256-armv4.S:3854: Error: bad arguments to instruction -- `orr r11,r12' crypto/ec/ecp_nistz256-armv4.S:3855: Error: bad arguments to instruction -- `orrs r11,r14' CLA: trivial Fixes #12848 Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Kurt Roeckx <[email protected]> GH: #12854
openssl-machine
pushed a commit
that referenced
this pull request
Sep 20, 2020
Fix this error: crypto/ec/ecp_nistz256-armv4.S:3853: Error: bad arguments to instruction -- `orr r11,r10' crypto/ec/ecp_nistz256-armv4.S:3854: Error: bad arguments to instruction -- `orr r11,r12' crypto/ec/ecp_nistz256-armv4.S:3855: Error: bad arguments to instruction -- `orrs r11,r14' CLA: trivial Fixes #12848 Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Kurt Roeckx <[email protected]> GH: #12854 (cherry picked from commit b5f8256)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix this error:
crypto/ec/ecp_nistz256-armv4.S:3853: Error: bad arguments to instruction -- orr r11,r10
crypto/ec/ecp_nistz256-armv4.S:3854: Error: bad arguments to instruction -- orr r11,r12
crypto/ec/ecp_nistz256-armv4.S:3855: Error: bad arguments to instruction -- orrs r11,r14
Always use 3-operand form instructions
CLA: trivial
Fixes #12848