Introduce X509_add_cert[s] simplifying various additions to cert lists#12615
Merged
openssl-machine merged 1 commit intoopenssl:masterfrom Aug 12, 2020
Merged
Conversation
DDvO
force-pushed
the
cleanup_sk_X509_add1_cert
branch
from
adba946 to
c098b22
Compare
Contributor
Author
|
Rebased to take advantage of the (unrelated) mem leak fix #12613. |
mattcaswell
requested changes
Aug 10, 2020
DDvO
force-pushed
the
cleanup_sk_X509_add1_cert
branch
from
c098b22 to
1ff01d7
Compare
DDvO
changed the title
Contributor
Author
|
Thanks @mattcaswell for your very swift and useful comments. |
mattcaswell
requested changes
Aug 11, 2020
DDvO
force-pushed
the
cleanup_sk_X509_add1_cert
branch
from
1ff01d7 to
b479b3f
Compare
DDvO
changed the title
Contributor
Author
|
I've done the respective fixups and squashed the commits. |
mattcaswell
added
the
approval: done
DDvO
added
the
approval: ready to merge
Contributor
Author
|
Setting "ready to merge" manually because the only Travis issue reported is unrelated (CI-internal issue "Automatic restarts limited"). |
Reviewed-by: Matt Caswell <[email protected]> (Merged from openssl#12615)
DDvO
force-pushed
the
cleanup_sk_X509_add1_cert
branch
from
b479b3f to
eeccc23
Compare
Contributor
Author
|
Merged - thanks @mattcaswell |
swenkeratmicrosoft
pushed a commit
to swenkeratmicrosoft/openssl
that referenced
this pull request
Sep 1, 2020
Reviewed-by: Matt Caswell <[email protected]> (Merged from openssl#12615)
DDvO
added a commit
to siemens/openssl
that referenced
this pull request
Mar 6, 2021
This is a follow-up on openssl#12615. Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#14436)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds two versatile cert addition functions and uses them for simplifying various code
that adds (lists of) certificates to certificate lists, including reference count and error handling.
This includes options for leaving out duplicate certs and/or self-signed certs and for prepending rather than appending.
Checklist