Skip to content

Comments

Apple Silicon Support#12591

Closed
MaddTheSane wants to merge 2 commits intoopenssl:masterfrom
MaddTheSane:appleSiSupport
Closed

Apple Silicon Support#12591
MaddTheSane wants to merge 2 commits intoopenssl:masterfrom
MaddTheSane:appleSiSupport

Conversation

@MaddTheSane
Copy link
Contributor

@MaddTheSane MaddTheSane commented Aug 5, 2020

Related to #12369, but targets the current head.
Also closes #12254.
This adds a darwin64-arm64 configuration for Apple Silicon, as well as a "legacy" darwin64-arm64-cc configuration.

This has not been tested on the DTK.

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Aug 5, 2020
@mattcaswell
Copy link
Member

mattcaswell commented Aug 6, 2020

Did you independently write this, or was this based on the work of @stuartcarnie in #12369? If the latter, please could you acknowledge him in the commit message.

We will need a CLA:
https://www.openssl.org/policies/cla.html

@MaddTheSane
Copy link
Contributor Author

MaddTheSane commented Aug 6, 2020

Other than perlasm_scheme, this was made independently.

@MaddTheSane
Copy link
Contributor Author

MaddTheSane commented Aug 7, 2020

CLA e-mail sent.

@paulidale paulidale closed this Aug 7, 2020
@paulidale paulidale reopened this Aug 7, 2020
@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement label Aug 7, 2020
@paulidale paulidale added approval: review pending This pull request needs review by a committer branch: master Applies to master branch labels Aug 7, 2020
@mattcaswell
Copy link
Member

mattcaswell commented Aug 7, 2020

The test_rand mem leak in travis is surprising but it is difficult to see that it is at all related to this PR.

@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Aug 7, 2020
@paulidale
Copy link
Contributor

paulidale commented Aug 7, 2020

That looks like the memory leak I addressed in #12509, I thought I'd caused it with the changes there but possibly not.

@openssl-machine
Copy link
Collaborator

openssl-machine commented Aug 8, 2020

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@mattcaswell mattcaswell added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Aug 10, 2020
@mattcaswell
Copy link
Member

mattcaswell commented Aug 10, 2020

Pushed! Thanks.

openssl-machine pushed a commit that referenced this pull request Aug 10, 2020
@MaddTheSane @mattcaswell
Initial Apple Silicon support.
23f0437 
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from #12591)
swenkeratmicrosoft pushed a commit to swenkeratmicrosoft/openssl that referenced this pull request Sep 1, 2020
@MaddTheSane
Initial Apple Silicon support.
789c551 
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#12591)
@adib adib mentioned this pull request Sep 15, 2020
Closed
@felixbuenemann felixbuenemann mentioned this pull request Nov 22, 2020
Closed
@MaddTheSane MaddTheSane deleted the appleSiSupport branch December 19, 2020 04:03
cth103 pushed a commit to cth103/openssl that referenced this pull request Jan 3, 2021
@MaddTheSane @cth103
Initial Apple Silicon support.
f33553d 
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#12591)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattcaswell mattcaswell mattcaswell approved these changes

@paulidale paulidale paulidale approved these changes

Assignees

No one assigned

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for building Apple Silicon

4 participants

@MaddTheSane @mattcaswell @paulidale @openssl-machine