Closed
Conversation
Fixes openssl#12531 on master branch.
slontis
reviewed
Jul 30, 2020
slontis
reviewed
Jul 30, 2020
slontis
reviewed
Jul 30, 2020
| if (dest->parameter == NULL) | ||
| return 0; | ||
|
|
||
| /* Assuming this is also correct for a BOOL. |
slontis
added
approval: otc review pending
branch: master
Updated per review.
slontis
added
approval: review pending
Contributor
Author
|
No worries at all.
On Jul 29, 2020, at 9:18 PM, Shane <[email protected]<mailto:[email protected]>> wrote:
@slontis approved this pull request.
Thanks for your patience..
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#12557 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFSCNZMDFKSKJQJWA4ABOD3R6DC6ZANCNFSM4PLXUDZQ>.
|
mattcaswell
approved these changes
Jul 30, 2020
mattcaswell
added
approval: done
openssl-machine
removed
the
approval: done
Collaborator
|
This pull request is ready to merge |
openssl-machine
added
the
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
Aug 4, 2020
Fixes #12531 on master branch. Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Shane Lontis <[email protected]> (Merged from #12557)
Member
|
Thanks for fixing. Merged to master. |
swenkeratmicrosoft
pushed a commit
to swenkeratmicrosoft/openssl
that referenced
this pull request
Sep 1, 2020
Fixes openssl#12531 on master branch. Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Shane Lontis <[email protected]> (Merged from openssl#12557)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12531 on master branch.
Address comments from
#12531
Checklist