Closed
Conversation
A recently added certificate in test/certs expired causing test_verify to fail. This add a replacement certificate with a long expiry date.
mattcaswell
added
branch: master
This was referenced Jul 28, 2020
Member
Author
|
It seems strange that AppVeyor is passing in builds in spite of the problem fixed in this PR. It looks like the tests are not running properly in AppVeyor builds. |
Member
Author
|
Ping? This impacts all current builds... |
This was referenced Jul 28, 2020
romen
added
approval: done
paulidale
approved these changes
Jul 28, 2020
Contributor
|
Merged to master. |
openssl-machine
pushed a commit
that referenced
this pull request
Jul 28, 2020
A recently added certificate in test/certs expired causing test_verify to fail. This add a replacement certificate with a long expiry date. Reviewed-by: Nicola Tuveri <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #12549)
This was referenced Jul 30, 2020
Closed
swenkeratmicrosoft
pushed a commit
to swenkeratmicrosoft/openssl
that referenced
this pull request
Sep 1, 2020
A recently added certificate in test/certs expired causing test_verify to fail. This add a replacement certificate with a long expiry date. Reviewed-by: Nicola Tuveri <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#12549)
Contributor
|
This fix has a bug. |
Contributor
IMO it would have been better to keep the original cert and use |
Member
|
Please do not reopen pull requests with merged commits. Open a new issue or even better a PR to fix the problem. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recently added certificate in test/certs expired causing test_verify to fail.
This add a replacement certificate with a long expiry date.
Marking this as urgent because it is causing current build and Travis failures.