README.md: fix two leftovers from pull request #10545#12361
Closed
mspncp wants to merge 2 commits intoopenssl:masterfrom
Closed
README.md: fix two leftovers from pull request #10545#12361mspncp wants to merge 2 commits intoopenssl:masterfrom
mspncp wants to merge 2 commits intoopenssl:masterfrom
Conversation
mspncp
changed the title
mspncp
commented
Jul 2, 2020
README.md
Outdated
Comment on lines
-210
to
-216
Contributor
Author
There was a problem hiding this comment.
@openssl/omc can somebody of you please do me a favour and send me the correct access token for the appveyor badge? It can be obtained only by a GitHub project owner of the openssl/openssl project.
Member
There was a problem hiding this comment.
How does one get the access token?
Contributor
Author
There was a problem hiding this comment.
I would expect that you just have to follow the link mentioned in the comment and login with your GitHub account if you are not logged in already. If you have the correct permissions, you should see something like the following:
Contributor
Author
There was a problem hiding this comment.
I just tried it: If the login screen reappears, you don't have the necessary permissions.
README.md
Outdated
Comment on lines
231
to
224
Contributor
Author
There was a problem hiding this comment.
Just post the link here, I will insert it.
Contributor
Author
There was a problem hiding this comment.
All I need is the random part of the URL, which in my case is ikn2l4u1xsume63u.
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Thank you. Added in commit 4d75b684092527d50d2a82e40e2c0bf4f34ae0be.
mspncp
added
the
triaged: documentation
Contributor
Author
|
ping |
The AppVeyor badge was still showing the build state for the mspncp/openssl fork. This commit fixes a forgotten todo from openssl#10545.
The link to the OpenSSL Project Pages <openssl.github.io> actually points to an unfinished draft <mspncp.github.io>. The original intention of this pet project of mine was to have a website dedicated to describing the OpenSSL workflow on GitHub and to answer frequently asked questions related to pull requests and the review process. The progress on that project has stalled and I'm not so sure anymore whether it is good idea to have yet another project website. In particular since the OpenSSL Wiki has seen some revival and increased activity caused by the upcoming OpenSSL 3.0 release.
mspncp
force-pushed
the
pr-fix-some-10545-todos
branch
from
4d75b68 to
68da307
Compare
Contributor
Author
|
Rebased and autosquashed without further changes. Ping for second review. |
mattcaswell
approved these changes
Aug 10, 2020
mattcaswell
added
the
approval: done
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Aug 11, 2020
The AppVeyor badge was still showing the build state for the mspncp/openssl fork. This commit fixes a forgotten todo from #10545. Reviewed-by: Matt Caswell <[email protected]> (Merged from #12361)
openssl-machine
pushed a commit
that referenced
this pull request
Aug 11, 2020
The link to the OpenSSL Project Pages <openssl.github.io> actually points to an unfinished draft <mspncp.github.io>. The original intention of this pet project of mine was to have a website dedicated to describing the OpenSSL workflow on GitHub and to answer frequently asked questions related to pull requests and the review process. The progress on that project has stalled and I'm not so sure anymore whether it is good idea to have yet another project website. In particular since the OpenSSL Wiki has seen some revival and increased activity caused by the upcoming OpenSSL 3.0 release. Reviewed-by: Matt Caswell <[email protected]> (Merged from #12361)
Contributor
Author
swenkeratmicrosoft
pushed a commit
to swenkeratmicrosoft/openssl
that referenced
this pull request
Sep 1, 2020
The AppVeyor badge was still showing the build state for the mspncp/openssl fork. This commit fixes a forgotten todo from openssl#10545. Reviewed-by: Matt Caswell <[email protected]> (Merged from openssl#12361)
swenkeratmicrosoft
pushed a commit
to swenkeratmicrosoft/openssl
that referenced
this pull request
Sep 1, 2020
The link to the OpenSSL Project Pages <openssl.github.io> actually points to an unfinished draft <mspncp.github.io>. The original intention of this pet project of mine was to have a website dedicated to describing the OpenSSL workflow on GitHub and to answer frequently asked questions related to pull requests and the review process. The progress on that project has stalled and I'm not so sure anymore whether it is good idea to have yet another project website. In particular since the OpenSSL Wiki has seen some revival and increased activity caused by the upcoming OpenSSL 3.0 release. Reviewed-by: Matt Caswell <[email protected]> (Merged from openssl#12361)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit 02054d791a52f02de66844ef6f9384378fb2877d (master)
Author: Dr. Matthias St. Pierre [email protected]
Date: Thu Jul 2 20:00:03 2020 +0200
Author: Dr. Matthias St. Pierre [email protected]
Date: Thu Jul 2 20:04:44 2020 +0200