[EC][ASN1] Detect missing OID when serializing EC parameters and keys#12313
Closed
romen wants to merge 4 commits intoopenssl:masterfrom
Closed
[EC][ASN1] Detect missing OID when serializing EC parameters and keys#12313romen wants to merge 4 commits intoopenssl:masterfrom
romen wants to merge 4 commits intoopenssl:masterfrom
Conversation
The following built-in curves do not have an assigned OID: - Oakley-EC2N-3 - Oakley-EC2N-4 In general we shouldn't assume that an OID is always available. This commit detects such cases, raises an error and returns appropriate return values so that the condition can be detected and correctly handled by the callers, when serializing EC parameters or EC keys with the default `ec_param_enc:named_curve`. Fixes openssl#12306
…nd keys make update
romen
added
branch: master
This was referenced Jun 29, 2020
romen
commented
Jun 29, 2020
| } | ||
|
|
||
| if ((dsize = i2d(x, NULL)) < 0) { | ||
| if ((dsize = i2d(x, NULL)) <= 0) { |
…eters and keys Detect missing OID in serializer implementation
Member
Author
…C parameters and keys EC_R_MISSING_OID -> PROV_R_MISSING_OID
Member
Author
|
Inside the provider we can't use See fa55d57 |
Member
Author
t8m
approved these changes
Jul 2, 2020
t8m
added
approval: done
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
romen
added a commit
to romen/openssl
that referenced
this pull request
Jul 4, 2020
The following built-in curves do not have an assigned OID: - Oakley-EC2N-3 - Oakley-EC2N-4 In general we shouldn't assume that an OID is always available. This commit detects such cases, raises an error and returns appropriate return values so that the condition can be detected and correctly handled by the callers, when serializing EC parameters or EC keys with the default `ec_param_enc:named_curve`. Fixes openssl#12306 Reviewed-by: Tomas Mraz <[email protected]> (Merged from openssl#12313)
openssl-machine
pushed a commit
that referenced
this pull request
Jul 7, 2020
The following built-in curves do not have an assigned OID: - Oakley-EC2N-3 - Oakley-EC2N-4 In general we shouldn't assume that an OID is always available. This commit detects such cases, raises an error and returns appropriate return values so that the condition can be detected and correctly handled by the callers, when serializing EC parameters or EC keys with the default `ec_param_enc:named_curve`. Fixes #12306 Reviewed-by: Tomas Mraz <[email protected]> (Merged from #12313)
Member
Author
|
Merged to
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the analogous of #12312 for
master: they differ for themake updatecommit.