Add const to 'ppin' function parameter in d2i_X509.pod and d2i_DHparams.pod#12205
Closed
olszomal wants to merge 1 commit intoopenssl:masterfrom
Closed
Add const to 'ppin' function parameter in d2i_X509.pod and d2i_DHparams.pod#12205olszomal wants to merge 1 commit intoopenssl:masterfrom
olszomal wants to merge 1 commit intoopenssl:masterfrom
Conversation
CLA: trivial
kroeckx
approved these changes
Sep 16, 2020
kroeckx
added
approval: review pending
mattcaswell
approved these changes
Sep 17, 2020
mattcaswell
added
approval: done
openssl-machine
removed
the
approval: done
Collaborator
|
This pull request is ready to merge |
openssl-machine
added
the
approval: ready to merge
Member
|
matt: Do you agree this is trivial? |
Member
Yes |
openssl-machine
pushed a commit
that referenced
this pull request
Sep 21, 2020
CLA: trivial Reviewed-by: Kurt Roeckx <[email protected]> Reviewed-by: Matt Caswell <[email protected]> GH: #12205
openssl-machine
pushed a commit
that referenced
this pull request
Sep 21, 2020
CLA: trivial Reviewed-by: Kurt Roeckx <[email protected]> Reviewed-by: Matt Caswell <[email protected]> GH: #12205 (cherry picked from commit 434343f)
Member
|
merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function parameter ppin should be declared as the const unsigned char type according to this declaration
[skip ci]
CLA: trivial