Revert "TEST: make and use a fipsinstall script"#11592
Closed
levitte wants to merge 1 commit intoopenssl:masterfrom
Closed
Revert "TEST: make and use a fipsinstall script"#11592levitte wants to merge 1 commit intoopenssl:masterfrom
levitte wants to merge 1 commit intoopenssl:masterfrom
Conversation
Unfortunately, this won't work on MacOS because of system integrity measures on that platform, which clears DYLD_LIBRARY_PATH before starting a sub-process executable. Ref: https://developer.apple.com/library/archive/documentation/Security/Conceptual/System_Integrity_Protection_Guide/RuntimeProtections/RuntimeProtections.html This reverts commit ae6b654.
levitte
added
branch: master
2 tasks
mattcaswell
approved these changes
Apr 21, 2020
mattcaswell
added
approval: done
2 tasks
Member
Author
|
Hmmm, shouldn't this be urgent? |
t8m
added
the
severity: urgent
Member
|
It should. |
Member
Author
|
I'll merge it later this afternoon |
Contributor
|
Agreed, urgent. |
openssl-machine
pushed a commit
that referenced
this pull request
Apr 21, 2020
Unfortunately, this won't work on MacOS because of system integrity measures on that platform, which clears DYLD_LIBRARY_PATH before starting a sub-process executable. Ref: https://developer.apple.com/library/archive/documentation/Security/Conceptual/System_Integrity_Protection_Guide/RuntimeProtections/RuntimeProtections.html This reverts commit ae6b654. Reviewed-by: Matt Caswell <[email protected]> (Merged from #11592)
Member
Author
|
Merged. 1e78a50 Revert "TEST: make and use a fipsinstall script" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, this won't work on MacOS because of system integrity
measures on that platform, which clears DYLD_LIBRARY_PATH before
starting a sub-process executable.
Ref: https://developer.apple.com/library/archive/documentation/Security/Conceptual/System_Integrity_Protection_Guide/RuntimeProtections/RuntimeProtections.html
This reverts commit ae6b654.