Fix a few more tests to use the new fipsinstall script#11580
Closed
mattcaswell wants to merge 1 commit intoopenssl:masterfrom
Closed
Fix a few more tests to use the new fipsinstall script#11580mattcaswell wants to merge 1 commit intoopenssl:masterfrom
mattcaswell wants to merge 1 commit intoopenssl:masterfrom
Conversation
Commit ae6b654 introduced a new script to make running fipsinstall easier. A few tests were added around the same time as that commit that still do it the old way - so we fix those up.
mattcaswell
added
branch: master
This was referenced Apr 20, 2020
Contributor
|
Assuming CIs agree |
paulidale
added
approval: done
Member
|
Maybe this should be titled - 'break a few more tests on mac' :). |
slontis
requested changes
Apr 21, 2020
Member
slontis
left a comment
slontis
left a comment
There was a problem hiding this comment.
Please dont merge this until existing problems are fixed on MAC.
Member
Author
|
Closing due to #11592 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit ae6b654 introduced a new script to make running fipsinstall
easier. A few tests were added around the same time as that commit that
still do it the old way - so we fix those up.
Checklist