Skip to content

Comments

evptest: set the DESX provider to be the legacy provider.#11573

Closed
paulidale wants to merge 1 commit intoopenssl:masterfrom
paulidale:mac-fix-1
Closed

evptest: set the DESX provider to be the legacy provider.#11573
paulidale wants to merge 1 commit intoopenssl:masterfrom
paulidale:mac-fix-1

Conversation

@paulidale
Copy link
Contributor

@paulidale paulidale commented Apr 20, 2020 •
edited
Loading

This fixes the first of the two Mac build errors. In this case the legacy provider isn't being used for DESX and the load fails. It's not clear why this isn't the case everywhere else.

  • documentation is added or updated
  • tests are added or updated

@paulidale paulidale added branch: master Applies to master branch severity: urgent Fixes an urgent issue (exempt from 24h grace period) labels Apr 20, 2020
@paulidale paulidale mentioned this pull request Apr 20, 2020
Closed
@paulidale
Copy link
Contributor Author

paulidale commented Apr 20, 2020 •
edited
Loading

I'm marked this as urgent because it fixes a CI break.
However, there is no point merging it until the second Mac issue is dealt with.

@levitte
Copy link
Member

levitte commented Apr 20, 2020

It's not clear why this isn't the case everywhere else.

Not sure what you mean by that... all other DES related tests in that file are Triple-DES, which is still in the default provider...

@mattcaswell
Copy link
Member

mattcaswell commented Apr 20, 2020

It's not clear why this isn't the case everywhere else.

Not sure what you mean by that

I think @paulidale meant why isn't this the case on all other platforms other than MAC. I'd still like to understand that.

@levitte
Copy link
Member

levitte commented Apr 20, 2020 •
edited
Loading

D'oh, Mac, not MAC!
Too early for this kind of confusion 😅

@levitte
Copy link
Member

levitte commented Apr 20, 2020

I just tried it manually on my Linux box:

: ; ./util/wrap.pl test/evp_test ../master/test/recipes/30-test_evp_data/evpciph.txt 
1..1
    # Subtest: run_file_tests
    1..1
    # INFO:  @ ../master/test/testutil/stanza.c:21
    # Reading ../master/test/recipes/30-test_evp_data/evpciph.txt
    # INFO:  @ ../master/test/testutil/stanza.c:122
    # Starting "DES Tests (various sources)" tests at line 22
    # INFO:  @ ../master/test/evp_test.c:552
    # DES-EDE3-CFB1 is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # DES-EDE3-CFB1 is fetched
    # INFO:  @ ../master/test/evp_test.c:2884
    # ../master/test/recipes/30-test_evp_data/evpciph.txt:39: Source of above error (aligned in-place, not fragmented); unexpected error CIPHERINIT_ERROR
    # 80:DB:0E:07:62:7F:00:00:error:digital envelope routines:evp_generic_fetch:fetch failed:../master/crypto/evp/evp_fetch.c:307:Default library context, Algorithm (DESX-CBC), Properties (<null>)
    # 80:DB:0E:07:62:7F:00:00:error:digital envelope routines:evp_generic_fetch:fetch failed:../master/crypto/evp/evp_fetch.c:307:Default library context, Algorithm (DESX-CBC), Properties ()
    # 80:DB:0E:07:62:7F:00:00:error:digital envelope routines:EVP_CipherInit_ex:initialization error:../master/crypto/evp/evp_enc.c:336:
    # INFO:  @ ../master/test/evp_test.c:552
    # DES-EDE3-CBC is fetched
    # INFO:  @ ../master/test/testutil/stanza.c:122
    # Starting "AES (from FIPS-197 test vectors)" tests at line 53
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-128-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-192-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-256-ECB is fetched
    # INFO:  @ ../master/test/testutil/stanza.c:122
    # Starting "AES tests from NIST document SP800-38A" tests at line 116
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-128-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-128-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-128-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-128-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-192-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-192-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-192-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-192-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-256-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-256-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-256-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-256-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-128-CBC is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-128-CBC is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-128-CBC is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-128-CBC is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-192-CBC is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-192-CBC is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-192-CBC is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-192-CBC is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-256-CBC is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-256-CBC is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-256-CBC is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-256-CBC is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-128-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-128-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-128-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-128-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-128-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-128-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-128-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-128-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-192-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-192-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-192-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-192-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-192-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-192-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-192-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-192-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-256-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-256-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-256-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-256-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-256-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-256-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-256-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-256-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-128-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-128-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-128-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-128-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-128-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-128-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-128-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-128-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-192-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-192-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-192-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-192-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-192-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-192-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-192-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-192-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-256-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-256-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-256-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-256-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-256-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-256-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-256-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # AES-256-OFB is fetched
    # INFO:  @ ../master/test/testutil/stanza.c:122
    # Starting "AES Counter test vectors from RFC3686" tests at line 658
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-ctr is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-ctr is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-ctr is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-192-ctr is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-192-ctr is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-192-ctr is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-256-ctr is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-256-ctr is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-256-ctr is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-ctr is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-256-ccm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-256-ccm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-256-ccm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-192-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-192-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-192-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-192-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-192-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-192-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-192-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-256-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-256-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-256-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-256-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-256-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-256-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-256-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-gcm is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-ocb is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-ocb is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-ocb is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-ocb is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-ocb is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-ocb is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-ocb is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-ocb is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-ocb is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-ocb is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-ocb is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-ocb is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-ocb is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-ocb is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-ocb is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-ocb is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-ocb is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-ocb is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-ocb is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-ocb is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-ocb is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-ocb is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-ocb is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-ocb is fetched
    # INFO:  @ ../master/test/testutil/stanza.c:122
    # Starting "AES XTS test vectors from IEEE Std 1619-2007" tests at line 1229
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:3174
    # skipping, providers not available: ../master/test/recipes/30-test_evp_data/evpciph.txt:1241
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-256-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-256-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-256-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-256-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-256-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # aes-128-xts is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # id-aes128-wrap is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # id-aes192-wrap is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # id-aes256-wrap is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # id-aes192-wrap is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # id-aes256-wrap is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # id-aes256-wrap is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # id-aes256-wrap is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # id-aes192-wrap-pad is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # id-aes192-wrap-pad is fetched
    # INFO:  @ ../master/test/testutil/stanza.c:122
    # Starting "Camellia tests from RFC3713" tests at line 1506
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-CBC is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-CBC is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-CBC is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-CBC is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-CBC is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-CBC is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-CBC is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-CBC is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-CBC is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-CBC is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-CBC is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-CBC is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-CTR is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-CTR is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-128-CTR is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-CTR is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-CTR is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-192-CTR is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-CTR is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-CTR is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # CAMELLIA-256-CTR is fetched
    # INFO:  @ ../master/test/testutil/stanza.c:122
    # Starting "ARIA test vectors from RFC5794 (and others)" tests at line 2207
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-128-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-192-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-256-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-128-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-128-CBC is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-128-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-128-CFB8 is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-128-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-128-CTR is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-192-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-192-CBC is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-192-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-192-CFB8 is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-192-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-192-CTR is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-256-ECB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-256-CBC is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-256-CFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-256-CFB8 is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-256-OFB is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-256-CTR is fetched
    # INFO:  @ ../master/test/testutil/stanza.c:122
    # Starting "ARIA GCM test vectors from RFC8269" tests at line 2351
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-128-GCM is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-256-GCM is fetched
    # INFO:  @ ../master/test/testutil/stanza.c:122
    # Starting "ARIA GCM self-generated test vectors" tests at line 2371
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-128-GCM is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-128-GCM is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-128-GCM is fetched
    # INFO:  @ ../master/test/testutil/stanza.c:122
    # Starting "ARIA CCM test vectors from IETF draft-ietf-avtcore-aria-srtp-02" tests at line 2404
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-128-CCM is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-256-CCM is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-128-CCM is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-256-CCM is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-128-CCM is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-256-CCM is fetched
    # INFO:  @ ../master/test/evp_test.c:552
    # ARIA-256-CCM is fetched
    # INFO:  @ ../master/test/testutil/stanza.c:32
    # Completed 308 tests with 1 errors and 1 skipped
    not ok 1 - ../master/test/recipes/30-test_evp_data/evpciph.txt
not ok 1 - run_file_tests

However:

: ; make test TESTS=test_evp
make depend && make _tests
make[1]: Entering directory '/home/levitte/gitwrk/openssl.net/official/_build'
make[1]: Leaving directory '/home/levitte/gitwrk/openssl.net/official/_build'
make[1]: Entering directory '/home/levitte/gitwrk/openssl.net/official/_build'
( SRCTOP=../master \
  BLDTOP=. \
  PERL="/usr/bin/perl" \
  EXE_EXT= \
  /usr/bin/perl ../master/test/run_tests.pl test_evp )
30-test_evp.t .. ok    
All tests successful.
Files=1, Tests=27,  9 wallclock secs ( 0.39 usr  0.12 sys +  8.00 cusr  0.43 csys =  8.94 CPU)
Result: PASS
make[1]: Leaving directory '/home/levitte/gitwrk/openssl.net/official/_build'

I have no clue yet why there's a difference...

@levitte
Copy link
Member

levitte commented Apr 20, 2020

Oh never mind, that's a config difference... still digging

@levitte
Copy link
Member

levitte commented Apr 20, 2020

This has me a bit worried:

https://travis-ci.org/github/openssl/openssl/jobs/677077667#L4735-L4746

# The results of this test will end up in test-runs/test_evp_fetch_prov
1..54
    # Subtest: ../../test/evp_fetch_prov_test
    1..1
    ok 1 - test_EVP_MD_fetch
../../util/wrap.pl ../../test/evp_fetch_prov_test -defaultctx => 0
ok 1 - running evp_fetch_prov_test using the default libctx
dyld: Library not loaded: /usr/local/lib/libssl.3.dylib
  Referenced from: /Users/travis/build/openssl/openssl/_build/tree/test-runs/test_evp_fetch_prov/../../apps/openssl
  Reason: image not found
../../util/wrap.pl /usr/bin/perl ../../../../_srcdist/test/fipsinstall.pl ../.. => 0
ok 2 - fipsinstall

@paulidale
Copy link
Contributor Author

paulidale commented Apr 20, 2020

This has me a bit worried

That's the second error. I did a very little digging today but didn't make any progress. My Mac build environment isn't ideal (gdb doesn't work and lldb is alien) and I'm quite stumped by why it tries to local from /usr/local.

@mattcaswell mattcaswell mentioned this pull request Apr 20, 2020
Closed
@slontis
Copy link
Member

slontis commented Apr 20, 2020

I did a very little digging today but didn't make any progress.

Maybe start by reverting the fipsinstall changes to see that this is what causes the issue..
The way it sets up the dso path looks a bit different (not that I understand how any of that perl stuff really works )

@levitte levitte added the approval: done This pull request has the required number of approvals label Apr 21, 2020
@levitte
Copy link
Member

levitte commented Apr 21, 2020

I've approved this now, because this PR does fix one issue, and needs to go in. It's ridiculous that this should be blocked because we have issues figuring out another issue. Let's take that to another PR.

@levitte levitte mentioned this pull request Apr 21, 2020
Closed
@slontis
Copy link
Member

slontis commented Apr 21, 2020

I think this is a band aid solution..
There is something fundamentally wrong here.
i.e: the other platforms work because it loads both the legacy AND default providers using the combined default and legacy . cnf file.

@slontis
Copy link
Member

slontis commented Apr 21, 2020

A better fix would be to revert the change that broke things until it is fixed. (Which I think is related to making the fips install perl code shared)

@levitte
Copy link
Member

levitte commented Apr 21, 2020

@slontis, this PR modifies evpciph.txt to ssay the DESX-CBC is available in the legacy provider, i.e. that the legacy provider must be present to perform that particular test. If that's a band-aid and you want to undo the underlying change, then we should partially revert #11419.

The other issue, which is that test/evp_fetch_prov_test.c fails on Mac, has nothing to do with this PR. My earlier comments in this regard were confused.

@slontis
Copy link
Member

slontis commented Apr 21, 2020

Err... Can you tell me what caused this to break?
It was not the legacy provider changes because they have been in for quite a while
i.e. something recently has caused a change in behaviour - changing this field when it worked before is a bit concerning if you dont understand why.

@levitte
Copy link
Member

levitte commented Apr 21, 2020

Err... Can you tell me what caused this to break?

I actually have no idea. I just looked at the test_evp, and realised that we run with default+legacy or fips only, so AvailableIn = default worked, but more by accident than anything else.

So, I don't quite know what's going on specifically with DESX-CBC, I just cannot see how that's related to the FIPS provider, at all.

@levitte
Copy link
Member

levitte commented Apr 21, 2020

So, fipsinstall.pl stuff worked out (see #11592). However, that still doesn't invalidate this PR. It should go in.

@DDvO
Copy link
Contributor

DDvO commented Apr 21, 2020

Can this be merged now?

@paulidale
Copy link
Contributor Author

paulidale commented Apr 21, 2020

I don't think this is a build breaking fix with the reversion of the fipsinstall.pl.
Plus the repository is locked.

@paulidale paulidale removed the severity: urgent Fixes an urgent issue (exempt from 24h grace period) label Apr 21, 2020
@levitte
Copy link
Member

levitte commented Apr 21, 2020

I don't think this is a build breaking fix

It isn't... should we add a run of evp_test where we only use the legacy provider? That would certainly uncover this kind of error. Not sure it's worth the while, though.

@DDvO DDvO mentioned this pull request Apr 21, 2020
Closed
2 tasks
openssl-machine pushed a commit that referenced this pull request Apr 22, 2020
@paulidale
evptest: set the DESX provider to be the legacy provider.
28308a2 
Reviewed-by: Richard Levitte <[email protected]>
(Merged from #11573)
@paulidale
Copy link
Contributor Author

paulidale commented Apr 22, 2020

Merged to master, thanks.

@paulidale paulidale closed this Apr 22, 2020
@paulidale paulidale deleted the mac-fix-1 branch April 22, 2020 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@levitte levitte levitte approved these changes

Assignees

No one assigned

Labels

approval: done This pull request has the required number of approvals branch: master Applies to master branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@paulidale @levitte @mattcaswell @slontis @DDvO