Skip to content

Comments

Travis matrix adjustments to avoid duplication and frequent timeouts#11468

Closed
t8m wants to merge 1 commit intoopenssl:masterfrom
t8m:travis-adjustments
Closed

Travis matrix adjustments to avoid duplication and frequent timeouts#11468
t8m wants to merge 1 commit intoopenssl:masterfrom
t8m:travis-adjustments

Conversation

@t8m
Copy link
Member

@t8m t8m commented Apr 3, 2020

The intention is to re-enable some clang build on linux and replace the constantly timeouting osx build with it.

@t8m t8m force-pushed the travis-adjustments branch 5 times, most recently from dabfb5f to ac60c4b Compare April 6, 2020 15:16
- do not exclude all clang builds on Linux
- exclude the constantly timeouting -fsanitize=address build on OS/X
- drop some mostly duplicate builds
- change the base linux distro to Bionic
- drop sudo as that is no longer needed - always on
- drop -D__NO_STRING_INLINES where not needed
- memleak test is not working with old clang
@t8m t8m force-pushed the travis-adjustments branch from ac60c4b to 731dad2 Compare April 6, 2020 16:41
@t8m t8m changed the title WIP: Playing with Travis adjustments Travis matrix adjustments to avoid duplication and frequent timeouts Apr 7, 2020
@t8m t8m added approval: review pending This pull request needs review by a committer branch: master Applies to master branch labels Apr 7, 2020
@t8m
Copy link
Member Author

t8m commented Apr 7, 2020

As you can see here https://travis-ci.com/github/t8m/openssl?utm_medium=notification&utm_source=email the only build not passing within the extended tests is the one with external krb5 test. That is no regression.

@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Apr 7, 2020
@kaduk
Copy link
Contributor

kaduk commented Apr 7, 2020

As you can see here https://travis-ci.com/github/t8m/openssl?utm_medium=notification&utm_source=email the only build not passing within the extended tests is the one with external krb5 test. That is no regression.

I thought we had the krb5 test working fairly recently, to while it may not be a local regression I am still interested to know how it came to be. I will go kick off a local build with the krb5 tests, at least...

@t8m
Copy link
Member Author

t8m commented Apr 8, 2020

As you can see here https://travis-ci.com/github/t8m/openssl?utm_medium=notification&utm_source=email the only build not passing within the extended tests is the one with external krb5 test. That is no regression.

I thought we had the krb5 test working fairly recently, to while it may not be a local regression I am still interested to know how it came to be. I will go kick off a local build with the krb5 tests, at least...

The last commit where krb5 test was passing is: f33ca11
The first commit where it is failing is: 30a4cda

However there were a few (rather innocently looking) commits in between where Travis did not run.

@t8m
Copy link
Member Author

t8m commented Apr 8, 2020

Actually the commits are not that innocent I suppose - most probably the krb5 build is broken due to some mix-up of system and local openssl after the change from shlib_wrap.sh to wrap.pl.

@t8m
Copy link
Member Author

t8m commented Apr 8, 2020

@kaduk I've reported it as #11492

@kaduk
Copy link
Contributor

kaduk commented Apr 8, 2020

Thanks! That does feel like a likely culprit, given what things look like in my local testing.
(And I agree that it's a separate issue that should not hold up this PR.)

@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@t8m t8m added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Apr 9, 2020
openssl-machine pushed a commit that referenced this pull request Apr 9, 2020
- do not exclude all clang builds on Linux
- exclude the constantly timeouting -fsanitize=address build on OS/X
- drop some mostly duplicate builds
- change the base linux distro to Bionic
- drop sudo as that is no longer needed - always on
- drop -D__NO_STRING_INLINES where not needed
- memleak test is not working with old clang

Reviewed-by: Richard Levitte <[email protected]>
(Merged from #11468)
@t8m
Copy link
Member Author

t8m commented Apr 9, 2020

Merged to master as fbc6efb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants