Fix CMP server cert verification w.r.t. 3GPP trust anchor exception#11448
Closed
DDvO wants to merge 3 commits intoopenssl:masterfrom
Closed
Fix CMP server cert verification w.r.t. 3GPP trust anchor exception#11448DDvO wants to merge 3 commits intoopenssl:masterfrom
DDvO wants to merge 3 commits intoopenssl:masterfrom
Conversation
DDvO
force-pushed
the
fix_cmp_server-cert_verify
branch
from
69820bf to
4c84488
Compare
Contributor
Author
|
On this PR Travis suffered not only from the usual timeout issue but also from So nothing due to the contents of this PR. |
Contributor
Author
|
@mattcaswell, could you please review this as well? |
Contributor
Author
|
@mattcaswell, I've just cherry-picked the core commit 1da8127 of this PR over to #11386 such that we can go on there. How best to proceed this this PR - should I keep it or merge also the remaining tow (rather small) into that PR? |
mattcaswell
approved these changes
Apr 6, 2020
Member
|
I think we should keep the PRs separate. I've just approved this one. |
mattcaswell
added
the
approval: done
DDvO
added a commit
to siemens/openssl
that referenced
this pull request
Apr 6, 2020
…n crypt/cmp/cmp_vfy.c" This reverts commit 03f6514. Fix will no longer be needed since openssl#11448 has just been approved.
openssl-machine
pushed a commit
that referenced
this pull request
Apr 7, 2020
…cmp/cmp_vfy.c Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: David von Oheimb <[email protected]> (Merged from #11448)
openssl-machine
pushed a commit
that referenced
this pull request
Apr 7, 2020
…509.c Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: David von Oheimb <[email protected]> (Merged from #11448)
openssl-machine
pushed a commit
that referenced
this pull request
Apr 7, 2020
…e_msg() Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: David von Oheimb <[email protected]> (Merged from #11448)
Contributor
Author
|
Pushed - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While preparing the upcoming chunk 12 (CLI-based tests) of the CMP contribution
I found two bugs related to the optional exceptional handling of trust anchors for 3GPP.
This PR fixes them and improves the diagnostic output of CMP server cert selection and verification.