Skip to content

Comments

Chunk 10 of CMP contribution to OpenSSL: CMP HTTP client and related tests#11404

Closed
DDvO wants to merge 2 commits intoopenssl:masterfrom
mpeylo:cmpossl_incremental10
Closed

Chunk 10 of CMP contribution to OpenSSL: CMP HTTP client and related tests#11404
DDvO wants to merge 2 commits intoopenssl:masterfrom
mpeylo:cmpossl_incremental10

Conversation

@DDvO
Copy link
Contributor

@DDvO DDvO commented Mar 25, 2020

Chunk 10 of CMP contribution to OpenSSL: CMP HTTP client and related tests

Also improves the generic HTTP client w.r.t. proxy and no_proxy options,
makes HTTP server/proxy address and port parameters more consistent,
and include minor other improvements of the generic HTTP client.
Makes use of the generic HTTP client for the CMP client implementation.

Checklist
  • documentation is added or updated
  • tests are added or updated

@DDvO
Copy link
Contributor Author

DDvO commented Mar 26, 2020

Strange that Travis still shows yellow in the CI status overview above although its details indicate that all its runs have passed 16 hours ago.

@DDvO
Copy link
Contributor Author

DDvO commented Mar 27, 2020

Travis again brought the usual false postitive (due to timeout).

@DDvO
Copy link
Contributor Author

DDvO commented Mar 27, 2020

Neat that the number of this PR ends in 404 - kind of suitable for an HTTP topic 😉

@DDvO
Copy link
Contributor Author

DDvO commented Mar 31, 2020

Thanks @mattcaswell for your review!
All comments addressed.

@DDvO
Copy link
Contributor Author

DDvO commented Mar 31, 2020

Travis failure is the usual timeout.

@mattcaswell mattcaswell added the approval: done This pull request has the required number of approvals label Apr 1, 2020
@DDvO
Copy link
Contributor Author

DDvO commented Apr 2, 2020

Great that this already approved - thanks @mattcaswell for your swift responses!

I'm going to merge this soon after the 24 hours have passed.
Just weird that GitHub still shows the Travis run as non-finished here, while the details indicate that all runs went fine yesterday.

@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

… tests

    Also improve the generic HTTP client w.r.t. proxy and no_proxy options.

    Certificate Management Protocol (CMP, RFC 4210) extension to OpenSSL
    Also includes CRMF (RFC 4211) and HTTP transfer (RFC 6712).
    Adds the CMP and CRMF API to libcrypto and the "cmp" app to the CLI.
    Adds extensive documentation and tests.
@DDvO DDvO force-pushed the cmpossl_incremental10 branch from 66438d6 to 4fcbc6d Compare April 2, 2020 16:28
@DDvO DDvO force-pushed the cmpossl_incremental10 branch from 4fcbc6d to a5e85e5 Compare April 2, 2020 16:31
openssl-machine pushed a commit that referenced this pull request Apr 2, 2020
… tests

    Also improve the generic HTTP client w.r.t. proxy and no_proxy options.

    Certificate Management Protocol (CMP, RFC 4210) extension to OpenSSL
    Also includes CRMF (RFC 4211) and HTTP transfer (RFC 6712).
    Adds the CMP and CRMF API to libcrypto and the "cmp" app to the CLI.
    Adds extensive documentation and tests.

Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: David von Oheimb <[email protected]>
(Merged from #11404)
openssl-machine pushed a commit that referenced this pull request Apr 2, 2020
… other improvements

Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: David von Oheimb <[email protected]>
(Merged from #11404)
@DDvO
Copy link
Contributor Author

DDvO commented Apr 2, 2020

Rebased, squashed to two commits, and merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: done This pull request has the required number of approvals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants