Closed
Conversation
Use memcpy when zero-termination is not requred to make it explict for the compiler to see what we are doing here. Fixes openssl#11392
Member
Author
|
typo in the commit message "required" will fix that when merging. note to myself, |
levitte
approved these changes
Mar 24, 2020
levitte
added
approval: done
Member
|
I've assumed this should be cherry picked to 1.1.1 as well and labled accordingly. |
Member
Author
|
Oh, long time ago that I looked at 1.1.1 |
Member
Author
|
1.1.1 does not seem to be affected. |
Collaborator
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
t8m
added
approval: ready to merge
Member
Author
|
Oh, no who did change the strncpy that change is not okay. |
2 tasks
Contributor
|
|
Contributor
|
Oh, meanwhile I realize it was not wrong, sorry for the confusion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use memcpy when zero-termination is not requred
to make it explict for the compiler to see what
we are doing here.
Fixes #11392
Checklist