Config edits 1#11369
Closed
richsalz wants to merge 6 commits intoopenssl:masterfrom
richsalz:config-edits-1
Closed
Config edits 1#11369richsalz wants to merge 6 commits intoopenssl:masterfrom richsalz:config-edits-1
richsalz wants to merge 6 commits intoopenssl:masterfrom
richsalz:config-edits-1
Conversation
slontis
reviewed
Mar 22, 2020
slontis
reviewed
Mar 22, 2020
2 tasks
paulidale
reviewed
Apr 1, 2020
Contributor
paulidale
left a comment
paulidale
left a comment
There was a problem hiding this comment.
Looks good for the most part. A few typos and some suggestions.
Contributor
Author
|
I pushed three fixup commits to address most of the issues. Thanks very much for the careful review! I marked things I fixed as resolved, still have one question and one discussion point. |
As the documentation points out, these fipsmodule.cnf fields are a MAC, not a digest or checksum. Rename them to be correct.
Contributor
Author
|
fixup commits pushed to address all known comments. seeking review. |
Contributor
|
ping |
t8m
approved these changes
May 15, 2020
t8m
added
approval: review pending
levitte
approved these changes
May 15, 2020
levitte
added
approval: done
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
May 19, 2020
Reviewed-by: Richard Levitte <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #11369)
openssl-machine
pushed a commit
that referenced
this pull request
May 19, 2020
Reviewed-by: Richard Levitte <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #11369)
openssl-machine
pushed a commit
that referenced
this pull request
May 19, 2020
Reviewed-by: Richard Levitte <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #11369)
openssl-machine
pushed a commit
that referenced
this pull request
May 19, 2020
As the documentation points out, these fipsmodule.cnf fields are a MAC, not a digest or checksum. Rename them to be correct. Reviewed-by: Richard Levitte <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #11369)
Member
|
Merged to master. Thank you, Rich! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on refactoring the config (".cnf") files for FIPS testing, I read some of the
manpages. This PR overhauls two of the cnf-related pages; config.pod will be in a separate PR.
This is related to #11347 (I needed to find this information to do that PR), and #11338 and a bit #11177. The ultimate goal is #11124, which is blocked by this PR and the other two.
This could be backported.
I suggest reviewers just look at the new page, and not try to read diffs.