Update CA.pl podpage, and script#11338
Closed
richsalz wants to merge 2 commits intoopenssl:masterfrom
richsalz:extra-ca-params
Closed
Update CA.pl podpage, and script#11338richsalz wants to merge 2 commits intoopenssl:masterfrom richsalz:extra-ca-params
richsalz wants to merge 2 commits intoopenssl:masterfrom
richsalz:extra-ca-params
Conversation
Closed
Merge the NOTES section into the relevant parts of the manpage. Add the $EXTRA parameter in consistent places (the end) to call commands. Document that multiple -extra-XXX might be needed.
t8m
reviewed
Mar 19, 2020
apps/CA.pl.in
Outdated
| my @dirs = ( "${CATOP}", "${CATOP}/certs", "${CATOP}/crl", | ||
| "${CATOP}/newcerts", "${CATOP}/private" ); | ||
| foreach my $d ( @dirs ) { | ||
| die "Directory $d exists" if -d $d; |
Member
There was a problem hiding this comment.
I'd prefer just printing a warning and continuing.
Contributor
Author
There was a problem hiding this comment.
The manpage says it stops. I would be VERY VERY concerned if someone accidentally ran the -newca flag and clobbered their old tree.
Member
There was a problem hiding this comment.
Hmm, but the current code does not stop. And this will break at least Fedora/RHEL installations where the directories are pre-created and preinstalled by the rpm package. Could you make the script stop if it encounters pre-existing index.txt or serial files?
Contributor
Author
There was a problem hiding this comment.
fixup commit pushed.
Warn if directories exist. Exit if index.txt or serial exists.
t8m
added
approval: review pending
Closed
Member
|
ping for the second review |
beldmit
approved these changes
Mar 22, 2020
beldmit
added
approval: done
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
beldmit
pushed a commit
that referenced
this pull request
Mar 23, 2020
Merge the NOTES section into the relevant parts of the manpage. Add the $EXTRA parameter in consistent places (the end) to call commands. Document that multiple -extra-XXX might be needed. Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from #11338)
Member
|
Merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge the NOTES section into the relevant parts of the manpage.
Add the $EXTRA parameter in consistent places (the end) to call
commands. Document that multiple -extra-XXX might be needed.
This is needed for #11124