Skip to content

Comments

Add dh keygen to provider#11332

Closed
slontis wants to merge 5 commits intoopenssl:masterfrom
slontis:prov_dh_keygen
Closed

Add dh keygen to provider#11332
slontis wants to merge 5 commits intoopenssl:masterfrom
slontis:prov_dh_keygen

Conversation

@slontis
Copy link
Member

@slontis slontis commented Mar 15, 2020 •
edited
Loading

Checklist
  • documentation is added or updated
  • tests are added or updated

mattcaswell
mattcaswell requested changes Mar 23, 2020
View reviewed changes
@mattcaswell mattcaswell mentioned this pull request Mar 25, 2020
Closed
levitte
levitte reviewed Mar 30, 2020
View reviewed changes
mattcaswell
mattcaswell reviewed Apr 10, 2020
View reviewed changes
mattcaswell
mattcaswell reviewed Apr 10, 2020
View reviewed changes
@mattcaswell mattcaswell mentioned this pull request Apr 10, 2020
Closed
@slontis slontis changed the title WIP: Add dh keygen to provider Add dh keygen to provider Apr 14, 2020
@slontis slontis marked this pull request as ready for review April 14, 2020 10:51
@mattcaswell
Copy link
Member

mattcaswell commented Apr 14, 2020

Needs a rebase

@slontis slontis added approval: review pending This pull request needs review by a committer branch: master Applies to master branch labels Apr 14, 2020
@slontis
Copy link
Member Author

slontis commented Apr 14, 2020

This will be rebased once its dependant PR #11303 is merged.

mattcaswell
mattcaswell approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming the CIs agree after rebase

@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Apr 14, 2020
@levitte
Copy link
Member

levitte commented Apr 15, 2020

That last rebase, how much did you have to change? I did notice that #11303 had some #if 0'd code that was meant for this PR...

@slontis
Copy link
Member Author

slontis commented Apr 15, 2020

Not too much for the rebase.. it only just removed the dsa keygen as this was already part of this PR up until a day or 2 ago... The second commit shows a few names that changed from nid to uid.

@slontis
Copy link
Member Author

slontis commented Apr 15, 2020

I think I will wait for travis to pass on this one at least.

@levitte
Copy link
Member

levitte commented Apr 15, 2020

I think I will wait for travis to pass on this one at least.

Travis looks stalled. #11311 has been in a wait state for at least an hour... :-/

@openssl-machine
Copy link
Collaborator

openssl-machine commented Apr 15, 2020

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@slontis slontis added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals approval: ready to merge The 24 hour grace period has passed, ready to merge labels Apr 15, 2020
@slontis slontis added the approval: done This pull request has the required number of approvals label Apr 15, 2020
@slontis
Copy link
Member Author

slontis commented Apr 15, 2020

Thanks travis actually failed.. Even though it appeared green on this screen for me??

@mattcaswell
Copy link
Member

mattcaswell commented Apr 15, 2020

Fixups look trivial to me. I don't think there is a need to reset 24hr timer. @levitte do you agree?

@levitte
Copy link
Member

levitte commented Apr 15, 2020

Fixups look trivial to me. I don't think there is a need to reset 24hr timer. @levitte do you agree?

I agree re these

openssl-machine pushed a commit that referenced this pull request Apr 15, 2020
@slontis
Add DH keygen to providers
7165593 
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
(Merged from #11332)
@slontis slontis added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Apr 15, 2020
@slontis
Copy link
Member Author

slontis commented Apr 15, 2020

Thanks.. Merged to master.

@slontis slontis closed this Apr 15, 2020
This was referenced Apr 16, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@levitte levitte levitte approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees

No one assigned

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@slontis @mattcaswell @levitte @openssl-machine