Add dsa keygen to providers by slontis · Pull Request #11303 · openssl/openssl

slontis · 2020-03-11T04:51:47Z

Checklist

documentation is added or updated
tests are added or updated

slontis · 2020-03-11T04:53:44Z

The first commit is just a collapsed copy of #10289 and will be removed..

providers/implementations/keymgmt/dsa_kmgmt.c

levitte · 2020-03-11T09:57:34Z

This got me to raise #11306

levitte · 2020-03-11T10:05:38Z

I've tested this PR merged with the latest #10289 and with the mod suggested in #11303 (comment), and it worked flawlessly.

slontis · 2020-03-11T10:07:29Z

This PR is Not ready yet - major surgery in progress :)

levitte · 2020-03-11T10:11:33Z

Okie.

crypto/evp/pmeth_lib.c

providers/implementations/serializers/serializer_common.c

slontis · 2020-03-12T13:09:46Z

ping

providers/implementations/keymgmt/dsa_kmgmt.c

slontis · 2020-03-14T09:11:36Z

@levitte - on a related note (I am setting gindex and seed - which I can print out)..
What is the mechanism to retrieve these values out of the pkey (I dont want to go adding DSA_ API accessors if I can help it). It looks like I need a getparams type method to do this? (Could this be a todata operation??).

Being able to retrieve them from the generation is not the right place?
i.e- We can still load a key from file - and then need to be able to set and get these extra values out of a key (regardless of the operation??)

slontis · 2020-03-14T09:16:22Z

Updated to address review comments

apps/genpkey.c

levitte · 2020-03-16T03:17:44Z

Regarding extracting pkey values, we have the KEYMGMT export function. We need to craft functions around that. Some kind of inverse of the fromdata functionality, say?

slontis · 2020-03-30T05:45:40Z

dependent on #11365 (Needs to be rebased to remove commit 1)

levitte · 2020-04-08T19:42:28Z

Just to make sure I hadn't made a gaffe in #11422, I rebased this on top of current master...

: ; make test TESTS=test_cms 
make depend && make _tests
make[1]: Entering directory '/home/levitte/gitwrk/openssl.net/official/_build'
make[1]: Leaving directory '/home/levitte/gitwrk/openssl.net/official/_build'
make[1]: Entering directory '/home/levitte/gitwrk/openssl.net/official/_build'
( SRCTOP=../master \
  BLDTOP=. \
  PERL="/usr/bin/perl" \
  EXE_EXT= \
  /usr/bin/perl ../master/test/run_tests.pl test_cms )
80-test_cms.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/7 subtests 

Test Summary Report
-------------------
80-test_cms.t (Wstat: 256 Tests: 7 Failed: 1)
  Failed test:  4
  Non-zero exit status: 1
Files=1, Tests=7,  6 wallclock secs ( 0.06 usr  0.01 sys +  3.62 cusr  0.83 csys =  4.52 CPU)
Result: FAIL
make[1]: *** [Makefile:2386: _tests] Error 1
make[1]: Leaving directory '/home/levitte/gitwrk/openssl.net/official/_build'
make: *** [Makefile:2383: tests] Fel 2

I have no idea what's going on, but gotta admit I'm glad it wasn't me ;-)

levitte · 2020-04-08T19:43:17Z

That is to say, anything you can do to rebase this and make it work would be very helpful. Please?

slontis · 2020-04-14T10:22:45Z

@mattcaswell - please have another look.

mattcaswell

Approved assuming the CIs agree.

slontis · 2020-04-15T01:07:34Z

Had to rebase because of libcrypto.num - so also collapsed commits.
Will probably rebase again in the next 10 hours :)

mattcaswell · 2020-04-15T08:23:55Z

My approval holds in spite of rebases

include/openssl/core_names.h

slontis · 2020-04-15T10:03:25Z

Rebased again because of libcrypto.num

Moved some shared FFC code into the FFC files. Added extra paramgen parameters for seed, gindex. Fixed bug in ossl_prov util to print bignums.

slontis · 2020-04-15T10:37:30Z

Sigh.. Rebased again because of libcrypto.num

mattcaswell · 2020-04-15T10:43:43Z

Still good...

mattcaswell · 2020-04-15T10:49:45Z

Seems to be ready-to-merge

slontis · 2020-04-15T10:51:05Z

Should I wait until at least travis passes again?

mattcaswell · 2020-04-15T10:52:50Z

Should I wait until at least travis passes again?

If it was passing before the libcrypto.num conflicts then I see no need.

slontis · 2020-04-15T10:53:26Z

Ok What could go wrong :)

Moved some shared FFC code into the FFC files. Added extra paramgen parameters for seed, gindex. Fixed bug in ossl_prov util to print bignums. Reviewed-by: Matt Caswell <[email protected]> (Merged from #11303)

slontis · 2020-04-15T11:05:00Z

Merged to master..

richsalz · 2020-04-15T13:36:34Z

perhaps open an issue to track the "undocumented names in core_names.h"?

slontis added the branch: master Applies to master branch label Mar 11, 2020

levitte mentioned this pull request Mar 11, 2020

Implement domparam and key generation #10289

Merged

levitte reviewed Mar 11, 2020

View reviewed changes

providers/implementations/keymgmt/dsa_kmgmt.c Outdated Show resolved Hide resolved

levitte mentioned this pull request Mar 11, 2020

We don't test DSA key generation enough #11306

Closed

levitte reviewed Mar 11, 2020

View reviewed changes

crypto/evp/pmeth_lib.c Outdated Show resolved Hide resolved

slontis force-pushed the prov_dsa_keygen branch from 548f815 to ea7a239 Compare March 12, 2020 05:20

slontis commented Mar 12, 2020

View reviewed changes

providers/implementations/serializers/serializer_common.c Outdated Show resolved Hide resolved

slontis force-pushed the prov_dsa_keygen branch from 6609b39 to 2152e45 Compare March 12, 2020 11:05

slontis marked this pull request as ready for review March 12, 2020 11:10

slontis added the approval: review pending This pull request needs review by a committer label Mar 12, 2020

levitte reviewed Mar 13, 2020

View reviewed changes

providers/implementations/keymgmt/dsa_kmgmt.c Outdated Show resolved Hide resolved

levitte reviewed Mar 13, 2020

View reviewed changes

providers/implementations/keymgmt/dsa_kmgmt.c Outdated Show resolved Hide resolved

slontis commented Mar 15, 2020

View reviewed changes

apps/genpkey.c Outdated Show resolved Hide resolved

slontis force-pushed the prov_dsa_keygen branch from a725181 to 82c1e37 Compare March 15, 2020 23:34

slontis force-pushed the prov_dsa_keygen branch 2 times, most recently from 3318895 to 5f42670 Compare March 30, 2020 02:25

slontis mentioned this pull request Mar 30, 2020

Add dh keygen to provider #11332

Closed

2 tasks

levitte mentioned this pull request Apr 8, 2020

[WIP] PKCS#7 and CMS with provider side keys #11422

Closed

2 tasks

mattcaswell mentioned this pull request Apr 10, 2020

WIP: Alpha1 Test merge #11520

Closed

mattcaswell approved these changes Apr 14, 2020

View reviewed changes

slontis added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Apr 14, 2020

slontis force-pushed the prov_dsa_keygen branch from 24b0774 to f928fd9 Compare April 15, 2020 01:05

levitte reviewed Apr 15, 2020

View reviewed changes

include/openssl/core_names.h Outdated Show resolved Hide resolved

slontis force-pushed the prov_dsa_keygen branch from f928fd9 to d258443 Compare April 15, 2020 10:03

slontis self-assigned this Apr 15, 2020

slontis added 2 commits April 15, 2020 20:33

Add DSA keygen to provider

bf1fa75

Moved some shared FFC code into the FFC files. Added extra paramgen parameters for seed, gindex. Fixed bug in ossl_prov util to print bignums.

fixup! Add DSA keygen to provider

63eda9a

slontis force-pushed the prov_dsa_keygen branch from d258443 to 63eda9a Compare April 15, 2020 10:36

mattcaswell added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Apr 15, 2020

slontis closed this Apr 15, 2020

This was referenced Apr 16, 2020

Run sslapi test with the FIPS module #11508

Closed

Run ssl_test_new in fips #11511

Closed

Run ssl_test_old in fips #11534

Closed

Uh oh!

Comments

Conversation

slontis commented Mar 11, 2020

Checklist

Uh oh!

slontis commented Mar 11, 2020

Uh oh!

Uh oh!

levitte commented Mar 11, 2020

Uh oh!

levitte commented Mar 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

slontis commented Mar 11, 2020

Uh oh!

levitte commented Mar 11, 2020

Uh oh!

Uh oh!

Uh oh!

slontis commented Mar 12, 2020

Uh oh!

Uh oh!

Uh oh!

slontis commented Mar 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

slontis commented Mar 14, 2020

Uh oh!

Uh oh!

levitte commented Mar 16, 2020

Uh oh!

slontis commented Mar 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

levitte commented Apr 8, 2020

Uh oh!

levitte commented Apr 8, 2020

Uh oh!

slontis commented Apr 14, 2020

Uh oh!

mattcaswell left a comment

Choose a reason for hiding this comment

Uh oh!

slontis commented Apr 15, 2020

Uh oh!

mattcaswell commented Apr 15, 2020

Uh oh!

Uh oh!

slontis commented Apr 15, 2020

Uh oh!

slontis commented Apr 15, 2020

Uh oh!

mattcaswell commented Apr 15, 2020

Uh oh!

mattcaswell commented Apr 15, 2020

Uh oh!

slontis commented Apr 15, 2020

Uh oh!

mattcaswell commented Apr 15, 2020

Uh oh!

slontis commented Apr 15, 2020

Uh oh!

slontis commented Apr 15, 2020

Uh oh!

richsalz commented Apr 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

levitte commented Mar 11, 2020 •

edited

Loading

slontis commented Mar 14, 2020 •

edited

Loading

slontis commented Mar 30, 2020 •

edited

Loading