.travis.yml: where it matters, have build and source nesting levels differ#11186
Merged
openssl-machine merged 1 commit intoopenssl:masterfrom Mar 4, 2020
Merged
Conversation
levitte
added
branch: master
Member
Author
Member
Member
Author
|
Ah, I missed one spot. Fixed |
Member
|
You could drop the NOUPDATE variable support from .travis.yml that I've added in #11181 to workaround the progs update with no-deprecated. |
Member
|
Ah, my last comment is on wrong PR. |
levitte
force-pushed
the
travis-test-different-nesting-depths
branch
from
4b5aab2 to
5138162
Compare
Member
Author
|
Rebased, and now it should work out fine. |
Member
Author
|
Ping! CIs are fine, the Travis failure is a timeout |
romen
approved these changes
Mar 3, 2020
Member
romen
left a comment
romen
left a comment
There was a problem hiding this comment.
LGTM
Thanks for taking care of this!
romen
added
approval: done
levitte
added
approval: ready to merge
…iffer Where we build out of source, the source directory was _srcdist and the build directory was _build. That gives the same nesting level for both, which doesn't quite exercise all aspects of relative back references from build to source tree. Changing the build tree to be in _build/tree will challenge back references a bit more, and ensure a bit more that we got it right. Reviewed-by: Nicola Tuveri <[email protected]> (Merged from openssl#11186)
levitte
force-pushed
the
travis-test-different-nesting-depths
branch
from
5138162 to
6caf63e
Compare
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Where we build out of source, the source directory was _srcdist and
the build directory was _build. That gives the same nesting level for
both, which doesn't quite exercise all aspects of relative back
references from build to source tree.
Changing the build tree to be in _build/tree will challenge back
references a bit more, and ensure a bit more that we got it right.