Run apps/progs.pl from the build tree#11184
Conversation
`apps/progs.pl` is optimized to be run from the build tree, but `make update` currently runs it from the src tree. This can lead to failures in out-of-tree builds if the build tree is nested deeper than the src tree compared to the common ancestor node. This commit fixes the Makefile template to run `apps/progs.pl` from the build tree instead.
romen
added
branch: master
|
I am marking as Ping @levitte to evaluate if this fix matches what he has in mind and to evaluate if he agrees with the |
|
None of our CIs detected this failure, given that some scripts are adapted to be run from the src tree and some are adapted to be run from the build tree, should we have some build configuration target in which the out-of-tree builds are tested with different relative nesting depths for the src and build trees to verify that this kind of problem does not stay hidden in the future? |
romen
added
the
approval: review pending
|
Hahaha, I took this a step further, see #11185 |
|
Good idea regarding the nesting levels. That's a simple change in .travis.yml |
|
For a Travis fix, see #11186 |
Change relative nesting depth of the OOT build_dir Build failures seem to depend on what is the relative nesting level between $srcdir and $blddir. This seems potentially related to: - openssl#11184 - openssl#11185
2 participants
apps/progs.plis optimized to be run from the build tree, butmake updatecurrently runs it from the src tree.This can lead to failures in out-of-tree builds if the build tree is nested deeper than the src tree compared to the common ancestor node.
This commit fixes the Makefile template to run
apps/progs.plfrom the build tree instead.