Refactor CRMF_poposigningkey_init() to work with provider keys#11126
Merged
openssl-machine merged 1 commit intoopenssl:masterfrom Mar 9, 2020
Merged
Conversation
levitte
added
branch: master
This was referenced Feb 19, 2020
levitte
force-pushed
the
refactor-CRMF_poposigningkey_init-for-provider
branch
from
45d2c0a to
b7213a3
Compare
Member
|
Looks ok, but it would be good to have an opinion from @DDvO |
DDvO
approved these changes
Mar 7, 2020
Contributor
DDvO
left a comment
DDvO
left a comment
There was a problem hiding this comment.
Oops, so far I did not notice this PR and the review request for me.
Very good to take advantage of the existing function ASN1_item_sign().
Contributor
|
Would be good if |
DDvO
added
approval: done
Member
Author
|
Yeah, I plan on doing that, just not nownownow. |
slontis
added
approval: ready to merge
The code in this function was almost entirely a copy of the functionality in ASN1_item_sign(), so it gets refactored to actually call ASN1_item_sign(), and thereby automatically gets support for EVP_PKEYs with only provider side keys. Reviewed-by: David von Oheimb <[email protected]> (Merged from openssl#11126)
levitte
force-pushed
the
refactor-CRMF_poposigningkey_init-for-provider
branch
from
b7213a3 to
db4b3d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code in this function was almost entirely a copy of the
functionality in ASN1_item_sign(), so it gets refactored to actually
call ASN1_item_sign(), and thereby automatically gets support for
EVP_PKEYs with only provider side keys.