Skip to content

Adapt i2d_PUBKEY for provider only keys#11078

Merged
openssl-machine merged 1 commit intoopenssl:masterfrom
levitte:adapt-i2d_PUBKEY-for-provided-keys
Feb 14, 2020
Merged

Adapt i2d_PUBKEY for provider only keys#11078
openssl-machine merged 1 commit intoopenssl:masterfrom
levitte:adapt-i2d_PUBKEY-for-provided-keys

Conversation

@levitte
Copy link
Member

@levitte levitte commented Feb 12, 2020

It uses EVP_PKEY serializers to get the desired results.

@levitte levitte added branch: master Applies to master branch approval: review pending This pull request needs review by a committer labels Feb 12, 2020
@levitte levitte added this to the 3.0.0 milestone Feb 12, 2020
@levitte levitte force-pushed the adapt-i2d_PUBKEY-for-provided-keys branch from a1b6a5c to ba1cb7a Compare February 13, 2020 08:27
@levitte
Copy link
Member Author

levitte commented Feb 13, 2020

BTW, @slontis... if you're looking at this, you should also look at #11056. These two PRs are virtually copies of each other.

Copy link
Member

@slontis slontis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided the appveyor tests pass..

@levitte levitte added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Feb 13, 2020
@openssl-machine openssl-machine removed the approval: done This pull request has the required number of approvals label Feb 14, 2020
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@openssl-machine openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label Feb 14, 2020
It uses EVP_PKEY serializers to get the desired results.

Reviewed-by: Shane Lontis <[email protected]>
(Merged from openssl#11078)
@levitte levitte force-pushed the adapt-i2d_PUBKEY-for-provided-keys branch from 7b6c527 to cdb1663 Compare February 14, 2020 13:18
@openssl-machine openssl-machine merged commit cdb1663 into openssl:master Feb 14, 2020
@levitte levitte deleted the adapt-i2d_PUBKEY-for-provided-keys branch February 14, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants