Skip to content

Document OSSL_SERIALIZER_PUBKEY_TO_DER_PQ and friends#11071

Closed
levitte wants to merge 1 commit intoopenssl:masterfrom
levitte:doc-DER-serializer-propquery
Closed

Document OSSL_SERIALIZER_PUBKEY_TO_DER_PQ and friends#11071
levitte wants to merge 1 commit intoopenssl:masterfrom
levitte:doc-DER-serializer-propquery

Conversation

@levitte
Copy link
Member

@levitte levitte commented Feb 12, 2020

No description provided.

@levitte levitte added branch: master Applies to master branch approval: review pending This pull request needs review by a committer labels Feb 12, 2020
@levitte levitte requested a review from slontis February 12, 2020 12:06
@levitte levitte mentioned this pull request Feb 12, 2020
Merged
@slontis slontis closed this Feb 12, 2020
@slontis slontis reopened this Feb 12, 2020
@slontis
Copy link
Member

slontis commented Feb 12, 2020

travis failed so rebuilding..

slontis
slontis requested changes Feb 12, 2020
View reviewed changes
Copy link
Member

@slontis slontis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like travis has errors ..

@levitte
Copy link
Member Author

levitte commented Feb 12, 2020

Looks like travis has errors ..

.... argh

@levitte levitte force-pushed the doc-DER-serializer-propquery branch from ded26b4 to d68e233 Compare February 13, 2020 08:29
@levitte
Copy link
Member Author

levitte commented Feb 13, 2020

Travis failure fixed, I hope

slontis
slontis approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@slontis slontis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved provided the appveyor tests pass.

@levitte levitte added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Feb 13, 2020
@levitte
Copy link
Member Author

levitte commented Feb 13, 2020

Approved provided the appveyor tests pass.

If it doesn't, it's not relevant here. We don't do documentation checks on Appveyor 😉

@slontis
Copy link
Member

slontis commented Feb 13, 2020

If it doesn't, it's not relevant here. We don't do documentation checks on Appveyor 😉

Wouldnt suprise me if it failed. I have never seen util/other.syms before... :)

@levitte
Copy link
Member Author

levitte commented Feb 13, 2020

Wouldnt suprise me if it failed. I have never seen util/other.syms before... :)

We used to call it private.num (still do in 1.1.1), which was a bad name as it had nothing to do with any kind of enumeration.

Anyway, it's used by util/find-doc-nits only, so...

@levitte levitte force-pushed the doc-DER-serializer-propquery branch from 281f55c to 185abbb Compare February 15, 2020 05:45
openssl-machine pushed a commit that referenced this pull request Feb 15, 2020
@levitte
Document OSSL_SERIALIZER_PUBKEY_TO_DER_PQ and friends
9ea5924 
Reviewed-by: Shane Lontis <[email protected]>
(Merged from #11071)
@levitte
Copy link
Member Author

levitte commented Feb 15, 2020

Merged

9ea5924 Document OSSL_SERIALIZER_PUBKEY_TO_DER_PQ and friends

@levitte levitte closed this Feb 15, 2020
@levitte levitte deleted the doc-DER-serializer-propquery branch February 15, 2020 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slontis slontis slontis approved these changes

Assignees

No one assigned

Labels

approval: done This pull request has the required number of approvals branch: master Applies to master branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@levitte @slontis