Adapt i2d_PrivateKey for provider only keys#11056
Merged
openssl-machine merged 1 commit intoopenssl:masterfrom Feb 14, 2020
Merged
Adapt i2d_PrivateKey for provider only keys#11056openssl-machine merged 1 commit intoopenssl:masterfrom
openssl-machine merged 1 commit intoopenssl:masterfrom
Conversation
levitte
added
branch: master
mattcaswell
previously approved these changes
Feb 11, 2020
mattcaswell
dismissed
their stale review
Oh...wait....Travis red cross looks relevant. Otherwise looks ok.
levitte
changed the title
Member
Author
Yup, it's waiting for #11055 |
levitte
force-pushed
the
adapt-i2d_PrivateKey-for-provided-keys
branch
from
49755d1 to
8153df6
Compare
Member
Author
|
The CIs should be happier now |
levitte
force-pushed
the
adapt-i2d_PrivateKey-for-provided-keys
branch
from
8153df6 to
3f8452c
Compare
Member
Author
|
And with yet another rebase, the ECX issue should be no more... |
levitte
changed the title
slontis
reviewed
Feb 13, 2020
levitte
added
approval: done
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
It uses EVP_PKEY serializers to get the desired results. One might think that ddoing this might make things a bit dicy for existing serializers, as they should obviously use i2d functions. However, since our serializers use much more primitive functions such as i2d_ASN1_INTEGER(), or keytype specific ones such as i2d_RSAPrivateKey(), there is no clash. Reviewed-by: Shane Lontis <[email protected]> (Merged from openssl#11056)
levitte
force-pushed
the
adapt-i2d_PrivateKey-for-provided-keys
branch
from
3161a2f to
3e686af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It uses EVP_PKEY serializers to get the desired results.
One might think that ddoing this might make things a bit dicy for
existing serializers, as they should obviously use i2d functions.
However, since our serializers use much more primitive functions
such as i2d_ASN1_INTEGER(), or keytype specific ones such as
i2d_RSAPrivateKey(), there is no clash.