Skip to content

Add OSSL_SERIALIZER_PUBKEY_TO_DER_PQ and friends#11055

Merged
openssl-machine merged 1 commit intoopenssl:masterfrom
levitte:add-DER-serializer-propquery
Feb 12, 2020
Merged

Add OSSL_SERIALIZER_PUBKEY_TO_DER_PQ and friends#11055
openssl-machine merged 1 commit intoopenssl:masterfrom
levitte:add-DER-serializer-propquery

Conversation

@levitte
Copy link
Member

@levitte levitte commented Feb 11, 2020

It's already used internally, there's no reason the DER serializer
propqueries shouldn't be present alongside the PEM and TEXT ones.

@levitte levitte added branch: master Applies to master branch approval: review pending This pull request needs review by a committer labels Feb 11, 2020
@levitte levitte requested a review from mattcaswell February 11, 2020 05:27
@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Feb 11, 2020
Copy link
Member

@slontis slontis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Document in OSSL_SERIALIZER_CTX_new_by_EVP_PKEY.pod
If you want to ducument in dependant PR then that is fine..

@openssl-machine openssl-machine removed the approval: done This pull request has the required number of approvals label Feb 12, 2020
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@openssl-machine openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label Feb 12, 2020
@levitte
Copy link
Member Author

levitte commented Feb 12, 2020

@slontis, #11071

It's already used internally, there's no reason the DER serializer
propqueries shouldn't be present alongside the PEM and TEXT ones.

Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#11055)
@levitte levitte force-pushed the add-DER-serializer-propquery branch from 98cbb8e to 4b1aa16 Compare February 12, 2020 12:09
@openssl-machine openssl-machine merged commit 4b1aa16 into openssl:master Feb 12, 2020
@levitte levitte deleted the add-DER-serializer-propquery branch February 12, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants