Skip to content

OSSL_PARAM_allocate_from_text(): Allow detection of unsupported param keys#11049

Closed
paulidale wants to merge 3 commits intoopenssl:masterfrom
paulidale:from-text
Closed

OSSL_PARAM_allocate_from_text(): Allow detection of unsupported param keys#11049
paulidale wants to merge 3 commits intoopenssl:masterfrom
paulidale:from-text

Conversation

@paulidale
Copy link
Contributor

Alternative to #11046

  • documentation is added or updated
  • tests are added or updated

… exists.

The extra argument is a integer pointer and is optional.
When converting legacy controls to OSSL_PARAMs, return the unsupported -2
value correctly.
@paulidale
Copy link
Contributor Author

Rebased to remove conflicts.

@paulidale paulidale added the approval: review pending This pull request needs review by a committer label Feb 15, 2020
@paulidale paulidale added this to the 3.0.0 milestone Feb 15, 2020
@paulidale
Copy link
Contributor Author

Ping for review

@paulidale
Copy link
Contributor Author

Ping @openssl/committers

Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I prefer this one to #11046

@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Feb 20, 2020
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Feb 21, 2020
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@levitte
Copy link
Member

levitte commented Feb 21, 2020

@paulidale is away for a few days, so I'll merge this

@levitte
Copy link
Member

levitte commented Feb 21, 2020

Merged

2ee0dfa Params: add argument to the _from_text calls to indicate if the param exists.
292c8bd pmeth_lib: detect unsupported OSSL_PARAM.
e1dcac2 apps: distinguish between a parameter error and an unknown parameter.

@levitte levitte closed this Feb 21, 2020
openssl-machine pushed a commit that referenced this pull request Feb 21, 2020
… exists.

The extra argument is a integer pointer and is optional.

Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #11049)
openssl-machine pushed a commit that referenced this pull request Feb 21, 2020
When converting legacy controls to OSSL_PARAMs, return the unsupported -2
value correctly.

Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #11049)
openssl-machine pushed a commit that referenced this pull request Feb 21, 2020
@paulidale paulidale deleted the from-text branch February 21, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants