PROV: Ensure the AlgorithmIdentifier registers in DSA signature impl#11037
Closed
levitte wants to merge 1 commit intoopenssl:masterfrom
Closed
PROV: Ensure the AlgorithmIdentifier registers in DSA signature impl#11037levitte wants to merge 1 commit intoopenssl:masterfrom
levitte wants to merge 1 commit intoopenssl:masterfrom
Conversation
levitte
added
branch: master
When setting up the hash function for DSA signature, the encoded AlgorithmIdentifier for the DSA+hash combination is queried, but not stored, which leads to problems when signing ASN.1 items in libcrypto.
levitte
force-pushed
the
fix-DSA-implementation-20200207
branch
from
a8e153c to
312b421
Compare
slontis
approved these changes
Feb 8, 2020
slontis
added
approval: done
iamamoose
added
approval: ready to merge
Member
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Feb 10, 2020
When setting up the hash function for DSA signature, the encoded AlgorithmIdentifier for the DSA+hash combination is queried, but not stored, which leads to problems when signing ASN.1 items in libcrypto. Reviewed-by: Shane Lontis <[email protected]> (Merged from #11037)
Member
Author
|
Merged. b0593c0 PROV: Ensure the AlgorithmIdentifier registers in DSA signature impl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setting up the hash function for DSA signature, the encoded
AlgorithmIdentifier for the DSA+hash combination is queried, but not
stored, which leads to problems when signing ASN.1 items in libcrypto.