Adapt ASN1_item_sign_ctx() for use with provided keypairs#10920
Closed
levitte wants to merge 10 commits intoopenssl:masterfrom
Closed
Adapt ASN1_item_sign_ctx() for use with provided keypairs#10920levitte wants to merge 10 commits intoopenssl:masterfrom
levitte wants to merge 10 commits intoopenssl:masterfrom
Conversation
levitte
added
branch: master
Member
Author
|
The EXPERIMENTAL (#10797) test failure that triggered this is |
slontis
reviewed
Jan 22, 2020
slontis
reviewed
Jan 22, 2020
Member
|
Travis failure appears relevant. |
Member
Author
|
There will be corresponding work for ASN1_item_verify_ctx. That's a bit more involved because of horrid SM2 hackery in x_all.c. I'm pondering if I should make that a separate PR or include that in this PR. Thoughts? |
Member
Author
It should be fine now |
Member
Rebuilt the failing travis tests (now that the error in master is fixed). |
levitte
force-pushed
the
prov-algorithmidentifier
branch
from
6e0f879 to
4b10f1d
Compare
Member
|
There is a memory leak.. |
slontis
reviewed
Jan 24, 2020
slontis
reviewed
Jan 24, 2020
slontis
reviewed
Jan 24, 2020
Contributor
|
Is Travis relevant here? (fuzz test failure). |
Member
Its a memory leak picked up by asan |
Member
Author
|
Time for a re-review |
slontis
reviewed
Jan 24, 2020
slontis
reviewed
Jan 24, 2020
levitte
force-pushed
the
prov-algorithmidentifier
branch
from
1b593bc to
71ee5da
Compare
slontis
reviewed
Jan 26, 2020
The mechanism to do this is to ask the signature operation for the DER encoded AlgorithmIdentifier that corresponds to the combination of signature algorithm and digest algorithm.
levitte
force-pushed
the
prov-algorithmidentifier
branch
from
ec5fd73 to
62e2474
Compare
slontis
reviewed
Jan 26, 2020
slontis
approved these changes
Jan 26, 2020
slontis
added
approval: done
openssl-machine
pushed a commit
that referenced
this pull request
Jan 28, 2020
The mechanism to do this is to ask the signature operation for the DER encoded AlgorithmIdentifier that corresponds to the combination of signature algorithm and digest algorithm. Reviewed-by: Shane Lontis <[email protected]> (Merged from #10920)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 28, 2020
…tifiers Reviewed-by: Shane Lontis <[email protected]> (Merged from #10920)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 28, 2020
Reviewed-by: Shane Lontis <[email protected]> (Merged from #10920)
Member
Author
paulidale
reviewed
Jan 30, 2020
| ENCODE_ALGORITHMIDENTIFIER_SHAx(sha3_224, 5); | ||
| ENCODE_ALGORITHMIDENTIFIER_SHAx(sha3_256, 6); | ||
| ENCODE_ALGORITHMIDENTIFIER_SHAx(sha3_384, 7); | ||
| ENCODE_ALGORITHMIDENTIFIER_SHAx(sha3_512, 8); |
Contributor
There was a problem hiding this comment.
This is perfect for FIPS. It isn't so good if dsa-with-XXX exists for other digests. Probably more of an issue for ECDSA than here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mechanism to do this is to ask the signature operation for the DER
encoded AlgorithmIdentifier that corresponds to the combination of
signature algorithm and digest algorithm.
The provided DSA implementation is adapted to suit.