Adapt X509_PUBKEY_set() for use with provided implementations#10851
Closed
levitte wants to merge 3 commits intoopenssl:masterfrom
Closed
Adapt X509_PUBKEY_set() for use with provided implementations#10851levitte wants to merge 3 commits intoopenssl:masterfrom
levitte wants to merge 3 commits intoopenssl:masterfrom
Conversation
levitte
added
branch: master
levitte
force-pushed
the
prov-X509_PUBKEY_set
branch
2 times, most recently
from
c9c32fc to
3102cff
Compare
mattcaswell
requested changes
Jan 21, 2020
levitte
force-pushed
the
prov-X509_PUBKEY_set
branch
from
3102cff to
85a7657
Compare
mattcaswell
reviewed
Jan 22, 2020
Member
Author
|
Ping |
1 similar comment
Member
Author
|
Ping |
We do this by letting a serializer serialize the provider side key to a DER blob formatted according to the SubjectPublicKeyInfo structure (see RFC 5280), and deserialize it in libcrypto using the usual d2i function.
levitte
force-pushed
the
prov-X509_PUBKEY_set
branch
from
ef8cefe to
8ef3323
Compare
mattcaswell
approved these changes
Jan 27, 2020
mattcaswell
added
approval: done
openssl-machine
pushed a commit
that referenced
this pull request
Jan 28, 2020
We do this by letting a serializer serialize the provider side key to a DER blob formatted according to the SubjectPublicKeyInfo structure (see RFC 5280), and deserialize it in libcrypto using the usual d2i function. Reviewed-by: Matt Caswell <[email protected]> (Merged from #10851)
Member
Author
|
Merged. e56ba0e Adapt X509_PUBKEY_set() for use with provided implementations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do this by letting a serializer serialize the provider side key to
a DER blob formatted according to the SubjectPublicKeyInfo structure
(see RFC 5280), and deserialize it in libcrypto using the usual d2i
function.