Skip to content

EVP: Adapt EVP_PKEY Seal and Open for provider keys#10808

Closed
levitte wants to merge 7 commits intoopenssl:masterfrom
levitte:provider-key-open+seal
Closed

EVP: Adapt EVP_PKEY Seal and Open for provider keys#10808
levitte wants to merge 7 commits intoopenssl:masterfrom
levitte:provider-key-open+seal

Conversation

@levitte
Copy link
Member

@levitte levitte commented Jan 10, 2020

This affects the following function, which can now deal with provider
side keys:

  • EVP_SealInit()
  • EVP_OpenInit()

@levitte levitte added branch: master Applies to master branch approval: review pending This pull request needs review by a committer labels Jan 10, 2020
@levitte
Copy link
Member Author

levitte commented Jan 13, 2020

Ping

paulidale
paulidale previously approved these changes Jan 13, 2020
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jan 13, 2020
@mattcaswell mattcaswell added approval: review pending This pull request needs review by a committer and removed approval: done This pull request has the required number of approvals labels Jan 13, 2020
@levitte levitte force-pushed the provider-key-open+seal branch from a08e87f to 5bf604f Compare January 15, 2020 12:25
@levitte
Copy link
Member Author

levitte commented Jan 16, 2020

Ping

@levitte levitte force-pushed the provider-key-open+seal branch 2 times, most recently from 504a484 to 95cb069 Compare January 18, 2020 04:54
@levitte levitte force-pushed the provider-key-open+seal branch from 95cb069 to ad7059d Compare January 21, 2020 20:18
@levitte levitte dismissed paulidale’s stale review January 22, 2020 13:12

Needs re-approval

@levitte levitte requested review from paulidale and slontis January 22, 2020 13:12
@levitte levitte requested a review from mattcaswell January 22, 2020 13:12
@levitte
Copy link
Member Author

levitte commented Jan 23, 2020

Ping

@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jan 24, 2020
openssl-machine pushed a commit that referenced this pull request Jan 25, 2020
This affects the following function, which can now deal with provider
side keys:

- EVP_SealInit()
- EVP_OpenInit()

Reviewed-by: Shane Lontis <[email protected]>
(Merged from #10808)
@levitte
Copy link
Member Author

levitte commented Jan 25, 2020

Merged.

9420b40 EVP: Adapt EVP_PKEY Seal and Open for provider keys

@levitte levitte closed this Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: done This pull request has the required number of approvals branch: master Applies to master branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants