Tweak option error messages#10774
Closed
richsalz wants to merge 2 commits intoopenssl:masterfrom
richsalz:fix-unknown-message
Closed
Tweak option error messages#10774richsalz wants to merge 2 commits intoopenssl:masterfrom richsalz:fix-unknown-message
richsalz wants to merge 2 commits intoopenssl:masterfrom
richsalz:fix-unknown-message
Conversation
Better messages for unknown option, unknown cipher, unknown digest. Fixes #10773
Contributor
|
A great impovement, indeed! But don't you think it would make the output even more readable if you would add colons? |
mspncp
added
branch: 1.1.1
Contributor
A cherry-pick to 1.1.1. would be o.k for me. After all, it's an improvement of the error diagnostics. |
Contributor
Author
|
fixup commit pushed. |
mspncp
added
the
approval: review pending
beldmit
approved these changes
Jan 7, 2020
paulidale
added
approval: done
paulidale
approved these changes
Jan 8, 2020
Member
|
It's at least arguable of this should go back to 1.1.1. Changed error messages in a stable release is generally not seen as stable. I would rather avoid that. |
Member
|
I have removed the branch: 1.1.1 label - consider it a "hold" for any back fit. |
Contributor
That's ok for me. I was already tempted to ask whether error messages are considered part of the 'API contract', but then I refrained from doing it. Anyway, if there is a non-negligible chance to break existing scripts because they parse the error messages, it's better not to do it. |
paulidale
added
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
Jan 10, 2020
Better messages for unknown option, unknown cipher, unknown digest. Fixes #10773 Reviewed-by: Dmitry Belyavskiy <[email protected]> Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Matthias St. Pierre <[email protected]> (Merged from #10774)
Contributor
|
Merged to master as e0e68f9, thanks! |
danbev
pushed a commit
to nodejs/node
that referenced
this pull request
Apr 3, 2021
OpenSSL 3 has changed the format of the error message for an unknown option to the CLI. Update the test to allow for the older and newer message formats. PR-URL: #38027 Refs: openssl/openssl#10774 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins
pushed a commit
to nodejs/node
that referenced
this pull request
Apr 4, 2021
OpenSSL 3 has changed the format of the error message for an unknown option to the CLI. Update the test to allow for the older and newer message formats. PR-URL: #38027 Refs: openssl/openssl#10774 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins
pushed a commit
to nodejs/node
that referenced
this pull request
Apr 5, 2021
OpenSSL 3 has changed the format of the error message for an unknown option to the CLI. Update the test to allow for the older and newer message formats. PR-URL: #38027 Refs: openssl/openssl#10774 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better messages for unknown option, unknown cipher, unknown digest.
Fixes #10773
Should be easy to cherry-pick.