Move random-related defines to "crypto/rand.h" [1.1.1]#10761
Closed
mspncp wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
Closed
Move random-related defines to "crypto/rand.h" [1.1.1]#10761mspncp wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
mspncp wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
Conversation
mspncp
added
approval: review pending
This fixes commit 7b18d1a, which moved the DEVRANDOM and DEVRANDOM_EGD defines into rand_unix.c. That change introduced the regression that the compiler complains about missing declarations in apps/version.c when OpenSSL is configured using `--with-rand-seed=devrandom` (resp. `--with-rand-seed=egd`) Fixes openssl#10759
mspncp
force-pushed
the
pr-move-random-defines-again-111
branch
from
61edd57 to
6089fed
Compare
t8m
approved these changes
Jan 6, 2020
Member
t8m
left a comment
t8m
left a comment
There was a problem hiding this comment.
The patch looks OK. Although another option would be to just revert the commit that introduced the regression.
t8m
added
approval: done
Contributor
Author
I did in fact consider this option for 1.1.1, but that would have had the disadvantage that the code which originally came from |
levitte
reviewed
Jan 6, 2020
Contributor
Author
|
Ok, Tim approved #10764 in record time. I feel consent about reverting instead of fixing on 1.1.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes commit 7b18d1a, which moved the
DEVRANDOM and DEVRANDOM_EGD defines into rand_unix.c. That change introduced
the regression that the compiler complains about missing declarations in
crypto/info.c when OpenSSL is configured using
--with-rand-seed=devrandom(resp.
--with-rand-seed=egd)Fixes #10759