Skip to content

Fix travis timeout by excluding arm64 gcc -fsanitize=address build#10639

Closed
slontis wants to merge 2 commits intoopenssl:masterfrom
slontis:travis_disable_arm64_address_sanitizer
Closed

Fix travis timeout by excluding arm64 gcc -fsanitize=address build#10639
slontis wants to merge 2 commits intoopenssl:masterfrom
slontis:travis_disable_arm64_address_sanitizer

Conversation

@slontis
Copy link
Member

@slontis slontis commented Dec 18, 2019

Travis constantly timing out after 50 minutes has finally annoyed me enough to fix it..

Checklist
  • documentation is added or updated
  • tests are added or updated

@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: omc review pending labels Dec 18, 2019
@richsalz
Copy link
Contributor

Build fix, so not subject to 24 hours?

@slontis slontis added severity: urgent Fixes an urgent issue (exempt from 24h grace period) approval: omc review pending labels Dec 19, 2019
@slontis slontis requested a review from mattcaswell December 19, 2019 01:33
@slontis slontis removed the approval: done This pull request has the required number of approvals label Dec 19, 2019
@slontis
Copy link
Member Author

slontis commented Dec 19, 2019

ping

Copy link
Contributor

@mspncp mspncp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@levitte levitte added approval: done This pull request has the required number of approvals and removed approval: omc review pending labels Dec 19, 2019
@mspncp
Copy link
Contributor

mspncp commented Dec 19, 2019

@levitte wouldn’t it be better to mark it ‚ready to merge‘ right away if it has the ‚urgent‘ label?

@slontis slontis added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Dec 19, 2019
@slontis slontis self-assigned this Dec 19, 2019
@levitte
Copy link
Member

levitte commented Dec 19, 2019

Good point.

openssl-machine pushed a commit that referenced this pull request Dec 19, 2019
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Matthias St. Pierre <[email protected]>
(Merged from #10639)
@slontis
Copy link
Member Author

slontis commented Dec 19, 2019

Thanks for reviewing quickly. Merged to master.

@slontis slontis closed this Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch severity: urgent Fixes an urgent issue (exempt from 24h grace period)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants