Fix build when enabling mdebug options.#10629
Closed
richsalz wants to merge 1 commit intoopenssl:masterfrom
richsalz:fix-rm-mdebug
Closed
Fix build when enabling mdebug options.#10629richsalz wants to merge 1 commit intoopenssl:masterfrom richsalz:fix-rm-mdebug
richsalz wants to merge 1 commit intoopenssl:masterfrom
richsalz:fix-rm-mdebug
Conversation
levitte
approved these changes
Dec 15, 2019
levitte
added
approval: review pending
Member
|
I can confirm this fixed all the issues I detected and reported in #10572! |
romen
reviewed
Dec 15, 2019
Member
romen
left a comment
romen
left a comment
There was a problem hiding this comment.
In general it looks good to me, I just have a doubt about the implementation of the deprecated functions not being surrounded by #ifdef guards (but I admit I did not follow closely enough @levitte latest endeavours in the battle for deprecation (I know things were recently changed in macros for definitions and in the configure/build.info but I am not entirely sure about what to do about the code implementing the deprecated declarations.).
So this could considered an approval if @levitte confirms that nothing else is required around the implementations.
romen
added
approval: done
openssl-machine
pushed a commit
that referenced
this pull request
Dec 18, 2019
Reviewed-by: Nicola Tuveri <[email protected]> Reviewed-by: Richard Levitte <[email protected]> Reviewed-by: Shane Lontis <[email protected]> (Merged from #10629)
Member
|
Thanks. Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.