Fix some missing OBJ_dup failure checks. #1057
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
+1 |
kroeckx
added
the
approval: done
Member
|
+1 |
FdaSilvaYY
force-pushed
the
fix-missing-failure-checks
branch
from
989e590 to
db0f786
Compare
Contributor
Author
|
Ping @richsalz, as this PR is ready to commit... |
Contributor
|
My $DAYJOB is taking precedence right now, others from the team now they have to step up :) |
Contributor
Author
|
Ok, I get it. I understand now, why your commit-rate has dropped ;) |
Fix some missing OBJ_dup failure checks. Merged from https://boringssl.googlesource.com/boringssl/+/0ce78a757d815c0dde9ed5884229f3a5b2cb3e9c%5E!
FdaSilvaYY
force-pushed
the
fix-missing-failure-checks
branch
from
db0f786 to
90e9865
Compare
Member
|
Merged! |
levitte
pushed a commit
that referenced
this pull request
May 16, 2016
Fix some missing OBJ_dup failure checks. Merged from https://boringssl.googlesource.com/boringssl/+/0ce78a757d815c0dde9ed5884229f3a5b2cb3e9c%5E! Reviewed-by: Kurt Roeckx <[email protected]> Reviewed-by: Richard Levitte <[email protected]> (Merged from #1057)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some missing OBJ_dup failure checks.
Merged from
https://boringssl.googlesource.com/boringssl/+/0ce78a757d815c0dde9ed5884229f3a5b2cb3e9c%5E!
It's a quick and short change.