CORE & PROV: make export of key data leaner through callback, take 2#10414
Closed
levitte wants to merge 2 commits intoopenssl:masterfrom
Closed
CORE & PROV: make export of key data leaner through callback, take 2#10414levitte wants to merge 2 commits intoopenssl:masterfrom
levitte wants to merge 2 commits intoopenssl:masterfrom
Conversation
levitte
added
branch: master
Member
|
Travis failures are relevant |
Member
Author
|
Darnit |
Member
Author
|
Oh wait, that's because #10412 isn't merged yet, and I haven't included it in this PR. |
mattcaswell
requested changes
Nov 12, 2019
Member
mattcaswell
left a comment
mattcaswell
left a comment
There was a problem hiding this comment.
This looks a lot neater. I just have one comment.
This was referenced Nov 12, 2019
levitte
force-pushed
the
lean-export-key-data-2
branch
from
fcf24e7 to
0039a75
Compare
mattcaswell
approved these changes
Nov 12, 2019
Member
mattcaswell
left a comment
mattcaswell
left a comment
There was a problem hiding this comment.
Approved subject to a clean CI run once #10412 is merged.
mattcaswell
added
approval: done
Exporting data from a provider owned domainparams or key is quite an ordeal, with having to figure out what parameter keys an implementation supports, call the export function a first time to find out how large each parameter buffer must be, allocate the necessary space for it, and call the export function again. So how about letting the export function build up the key data params and call back with that? This change implements exactly such a mechanism.
levitte
force-pushed
the
lean-export-key-data-2
branch
from
0039a75 to
2a7224b
Compare
Member
Author
|
#10412 now being merged, I've rebased this |
levitte
changed the title
Member
Author
|
CIs are happy, apart from the Appveyor things that aren't relevant here |
openssl-machine
pushed a commit
that referenced
this pull request
Nov 14, 2019
Exporting data from a provider owned domainparams or key is quite an ordeal, with having to figure out what parameter keys an implementation supports, call the export function a first time to find out how large each parameter buffer must be, allocate the necessary space for it, and call the export function again. So how about letting the export function build up the key data params and call back with that? This change implements exactly such a mechanism. Reviewed-by: Matt Caswell <[email protected]> (Merged from #10414)
Member
Author
|
Merged. 1640d48 CORE & PROV: make export of key data leaner through callback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exporting data from a provider owned domainparams or key is quite an
ordeal, with having to figure out what parameter keys an
implementation supports, call the export function a first time to find
out how large each parameter buffer must be, allocate the necessary
space for it, and call the export function again.
So how about letting the export function build up the key data params
and call back with that? This change implements exactly such a
mechanism.
This is an alternative to #10391