Skip to content

Comments

CORE: Add a generic callback function type#10412

Closed
levitte wants to merge 2 commits intoopenssl:masterfrom
levitte:300-callback-2
Closed

CORE: Add a generic callback function type#10412
levitte wants to merge 2 commits intoopenssl:masterfrom
levitte:300-callback-2

Conversation

@levitte
Copy link
Member

@levitte levitte commented Nov 11, 2019

This offers a very generic way to define a callback as well as calling
it.

@levitte levitte added branch: master Applies to master branch approval: review pending This pull request needs review by a committer labels Nov 11, 2019
@levitte levitte added this to the 3.0.0 milestone Nov 11, 2019
@levitte
Copy link
Member Author

levitte commented Nov 11, 2019

This is an alternative to #10390

@levitte
Copy link
Member Author

levitte commented Nov 11, 2019

So, I've made an alternative for #10391 that works with this PR (#10414). As for #10394 and #10289, I think I'll wait with the work on those until I have a yay or nay here (I sure hope I get a yay).

@levitte
Copy link
Member Author

levitte commented Nov 12, 2019

Ping.

@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Nov 12, 2019
This offers a very generic way to define a callback as well as calling
it.
@levitte
Copy link
Member Author

levitte commented Nov 14, 2019

Merged.

10e7216 CORE: Add a generic callback function type

@levitte levitte closed this Nov 14, 2019
openssl-machine pushed a commit that referenced this pull request Nov 14, 2019
This offers a very generic way to define a callback as well as calling
it.

Reviewed-by: Matt Caswell <[email protected]>
(Merged from #10412)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: done This pull request has the required number of approvals branch: master Applies to master branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants