Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s390x assembly pack: add z15 hw support for X25519,X448,Ed25519,Ed448 #10004

Closed
wants to merge 4 commits into from
Closed

s390x assembly pack: add z15 hw support for X25519,X448,Ed25519,Ed448 #10004

wants to merge 4 commits into from

Conversation

p-steuer
Copy link
Member

@p-steuer p-steuer commented Sep 24, 2019 •
edited
Loading

  • documentation is added or updated

edit: There are 3 small fixes in front. Since they are only relevant to master, i chose to include them in this feature PR.

@p-steuer p-steuer added the branch: master Merge to master branch label Sep 24, 2019
levitte
levitte reviewed Sep 25, 2019
View reviewed changes
crypto/evp/pmeth_lib.c
typedef int sk_cmp_fn_type(const char *const *a, const char *const *b);

static STACK_OF(EVP_PKEY_METHOD) *app_pkey_methods = NULL;

/* This array needs to be in order of NIDs */
static const EVP_PKEY_METHOD *standard_methods[] = {
static pmeth_fn standard_methods[] = {
Copy link
Member

@levitte levitte Sep 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This surprised me. It's not immediately obvious why the extra indirection of a function call is better, or makes any actual difference... Care to explain?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It enables architecture specific implementation of the pkey methods: The function returns a pointer to the architecture specific pkey method struct if the corresponding processor capabilities are detected. Otherwise, a pointer to the original pkey method struct is returned.

Copy link
Member Author

@p-steuer p-steuer Sep 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its similar to the implementation of switching between different EC_METHODs for the same curve: curve_list in ec_curve.c holds function pointers for each curve, and the functions will return a pointer to an appropriate EC_METHOD.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Ok, that makes sense.

@p-steuer
Copy link
Member Author

rebased

@p-steuer
Copy link
Member Author

addressed travis failure.

@p-steuer p-steuer force-pushed the s390x-ecc2 branch 3 times, most recently from ff3ca1c to 251bd1a Compare September 25, 2019 11:41
@p-steuer
s390x assembly pack: accelerate X25519, X448, Ed25519 and Ed448
cb12514 
using PCC and KDSA instructions.

Signed-off-by: Patrick Steuer <[email protected]>
@p-steuer p-steuer added the approval: done This pull request has the required number of approvals label Sep 25, 2019
@p-steuer
Copy link
Member Author

p-steuer commented Sep 25, 2019 •
edited
Loading

looks like appveyor is hanging. is it possible to trigger it again ?
edit: no its running, just seems slower than usual.

levitte pushed a commit that referenced this pull request Sep 25, 2019
@p-steuer
s390x assembly pack: fix msa3 stfle bit detection
b3681e2 
Signed-off-by: Patrick Steuer <[email protected]>

Reviewed-by: Richard Levitte <[email protected]>
(Merged from #10004)
levitte pushed a commit that referenced this pull request Sep 25, 2019
@p-steuer
s390x assembly pack: fix OPENSSL_s390xcap z15 cpu mask
ac037dc 
Signed-off-by: Patrick Steuer <[email protected]>

Reviewed-by: Richard Levitte <[email protected]>
(Merged from #10004)
levitte pushed a commit that referenced this pull request Sep 25, 2019
@p-steuer
s390x assembly pack: cleanse only sensitive fields
2281be2 
of instruction parameter blocks.

Signed-off-by: Patrick Steuer <[email protected]>

Reviewed-by: Richard Levitte <[email protected]>
(Merged from #10004)
levitte pushed a commit that referenced this pull request Sep 25, 2019
@p-steuer
s390x assembly pack: accelerate X25519, X448, Ed25519 and Ed448
19bd1fa 
using PCC and KDSA instructions.

Signed-off-by: Patrick Steuer <[email protected]>

Reviewed-by: Richard Levitte <[email protected]>
(Merged from #10004)
@p-steuer
Copy link
Member Author

merged to master.

@p-steuer p-steuer closed this Sep 25, 2019
@p-steuer p-steuer deleted the s390x-ecc2 branch September 25, 2019 15:34
p-steuer added a commit to p-steuer/openssl that referenced this pull request Nov 19, 2019
@p-steuer
s390x assembly pack: accelerate X25519, X448, Ed25519 and Ed448
5a08c76 
using PCC and KDSA instructions.

Signed-off-by: Patrick Steuer <[email protected]>

Reviewed-by: Richard Levitte <[email protected]>
(Merged from openssl#10004)

Signed-off-by: Patrick Steuer <[email protected]>
xnox pushed a commit to xnox/openssl that referenced this pull request Feb 25, 2020
@p-steuer @xnox
s390x assembly pack: fix msa3 stfle bit detection
f06db29 
Signed-off-by: Patrick Steuer <[email protected]>

Reviewed-by: Richard Levitte <[email protected]>
(Merged from openssl#10004)

(cherry picked from commit b3681e2)
Signed-off-by: Dimitri John Ledkov <[email protected]>
xnox pushed a commit to xnox/openssl that referenced this pull request May 28, 2020
@p-steuer @xnox
s390x assembly pack: fix msa3 stfle bit detection
cdacfe7 
Signed-off-by: Patrick Steuer <[email protected]>

Reviewed-by: Richard Levitte <[email protected]>
(Merged from openssl#10004)

(cherry picked from commit b3681e2)
Signed-off-by: Dimitri John Ledkov <[email protected]>
xnox pushed a commit to xnox/openssl that referenced this pull request May 28, 2020
@p-steuer @xnox
s390x assembly pack: fix OPENSSL_s390xcap z15 cpu mask
6860a7b 
Signed-off-by: Patrick Steuer <[email protected]>

Reviewed-by: Richard Levitte <[email protected]>
(Merged from openssl#10004)

(cherry picked from commit ac037dc)
Signed-off-by: Dimitri John Ledkov <[email protected]>
xnox pushed a commit to xnox/openssl that referenced this pull request May 28, 2020
@p-steuer @xnox
s390x assembly pack: accelerate X25519, X448, Ed25519 and Ed448
f70d40c 
using PCC and KDSA instructions.

Signed-off-by: Patrick Steuer <[email protected]>

Reviewed-by: Richard Levitte <[email protected]>
(Merged from openssl#10004)

Signed-off-by: Patrick Steuer <[email protected]>
(cherry picked from commit 56eb364ef5cf93e2658cd45fcffee435b80857b2)
Signed-off-by: Dimitri John Ledkov <[email protected]>
xnox pushed a commit to xnox/openssl that referenced this pull request Jun 25, 2020
@p-steuer @xnox
s390x assembly pack: fix msa3 stfle bit detection
797710a 
Signed-off-by: Patrick Steuer <[email protected]>

Reviewed-by: Richard Levitte <[email protected]>
(Merged from openssl#10004)

(cherry picked from commit b3681e2)
Signed-off-by: Dimitri John Ledkov <[email protected]>
xnox pushed a commit to xnox/openssl that referenced this pull request Jun 25, 2020
@p-steuer @xnox
s390x assembly pack: fix OPENSSL_s390xcap z15 cpu mask
648bf2e 
Signed-off-by: Patrick Steuer <[email protected]>

Reviewed-by: Richard Levitte <[email protected]>
(Merged from openssl#10004)

(cherry picked from commit ac037dc)
Signed-off-by: Dimitri John Ledkov <[email protected]>
xnox pushed a commit to xnox/openssl that referenced this pull request Jun 25, 2020
@p-steuer @xnox
s390x assembly pack: accelerate X25519, X448, Ed25519 and Ed448
d174e42 
using PCC and KDSA instructions.

Signed-off-by: Patrick Steuer <[email protected]>

Reviewed-by: Richard Levitte <[email protected]>
(Merged from openssl#10004)

Signed-off-by: Patrick Steuer <[email protected]>
(cherry picked from commit 56eb364ef5cf93e2658cd45fcffee435b80857b2)
Signed-off-by: Dimitri John Ledkov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p-steuer @levitte