Skip to content

Potential redundant code in crypto/pkcs7/pk7_lib.c #6977

@Jason2031

Description

@Jason2031

In crypto/pkcs7/pk7_lib.c there are 2 calls to function ASN1_INTEGER_set. It seems that the first call to ASN1_INTEGER_set is redundant. Codes related to this issue are as follow:

  135              == NULL)
  136              goto err;
  137:         ASN1_INTEGER_set(p7->d.signed_and_enveloped->version, 1);
  138:         if (!ASN1_INTEGER_set(p7->d.signed_and_enveloped->version, 1))
  139              goto err;
  140          p7->d.signed_and_enveloped->enc_data->content_type

Metadata

Metadata

Assignees

No one assigned

    Labels

    branch: 1.0.2Applies to OpenSSL_1_0_2-stable branch (EOL)branch: 1.1.1Applies to OpenSSL_1_1_1-stable branch (EOL)branch: masterApplies to master branch

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions