-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
Description
Hi! This was discovered by @picnixz when working on the ssl module in CPython upstream:
There seems to be a mismatch between one of the error codes in openssl.txt and the actual macro definition, which is screwing up a mechanism for handling errors on our end. The offending code is here:
openssl/include/openssl/comperr.h
Line 27 in 817a2b2
| # define COMP_R_BROTLI_ENCODE_ERROR 103 |
This differs from the provided openssl.txt file, which we use for code generation:
openssl/crypto/err/openssl.txt
Lines 410 to 411 in 817a2b2
| COMP_R_BROTLI_DEFLATE_ERROR:103:brotli deflate error | |
| COMP_R_BROTLI_ENCODE_ERROR:106:brotli encode error |
COMP_R_BROTLI_ENCODE_ERROR should be 103, not 106 here, and as far as I can tell, COMP_R_BROTLI_DEFLATE_ERROR doesn't exist anymore. It looks like things were changed in this commit: b67cb09
Let me or @picnixz know if there are any questions, thanks!