-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
Closed
Labels
branch: 1.1.1Applies to OpenSSL_1_1_1-stable branch (EOL)Applies to OpenSSL_1_1_1-stable branch (EOL)branch: 3.0Applies to openssl-3.0 branchApplies to openssl-3.0 branchbranch: masterApplies to master branchApplies to master branchgood first issueBite size change that could be a good startBite size change that could be a good starthelp wantedtriaged: bugThe issue/pr is/fixes a bugThe issue/pr is/fixes a bug
Description
d35ff2c added a X509_V_FLAG_NO_CHECK_TIME check into check_crl_time, but placed it after this code:
if (notify)
ctx->current_crl = crl;
This looks like a bug. notify is about a verify callback, but X509_V_FLAG_NO_CHECK_TIME skips all that. In particular, check_crl_time ends by undoing that state at the bottom, yet X509_V_FLAG_NO_CHECK_TIME skips that cleanup, and leaves a stray current_crl in there. Instead, the X509_V_FLAG_NO_CHECK_TIME check should have been placed at the beginning of the function.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
branch: 1.1.1Applies to OpenSSL_1_1_1-stable branch (EOL)Applies to OpenSSL_1_1_1-stable branch (EOL)branch: 3.0Applies to openssl-3.0 branchApplies to openssl-3.0 branchbranch: masterApplies to master branchApplies to master branchgood first issueBite size change that could be a good startBite size change that could be a good starthelp wantedtriaged: bugThe issue/pr is/fixes a bugThe issue/pr is/fixes a bug