-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
PR18353 breaks Windows build for x86 using nasm #18459
Copy link
Copy link
Closed
Labels
branch: 3.0Applies to openssl-3.0 branchApplies to openssl-3.0 branchbranch: 3.1Applies to openssl-3.1 (EOL)Applies to openssl-3.1 (EOL)branch: 3.2Applies to openssl-3.2 (EOL)Applies to openssl-3.2 (EOL)branch: masterApplies to master branchApplies to master branchinactiveThis label should not be applied to open issues anymore.This label should not be applied to open issues anymore.resolved: not a bugThe issue is not considered a bugThe issue is not considered a bugtriaged: bugThe issue/pr is/fixes a bugThe issue/pr is/fixes a bug
Description
Metadata
Metadata
Assignees
Labels
branch: 3.0Applies to openssl-3.0 branchApplies to openssl-3.0 branchbranch: 3.1Applies to openssl-3.1 (EOL)Applies to openssl-3.1 (EOL)branch: 3.2Applies to openssl-3.2 (EOL)Applies to openssl-3.2 (EOL)branch: masterApplies to master branchApplies to master branchinactiveThis label should not be applied to open issues anymore.This label should not be applied to open issues anymore.resolved: not a bugThe issue is not considered a bugThe issue is not considered a bugtriaged: bugThe issue/pr is/fixes a bugThe issue/pr is/fixes a bug
The
#ifdefand#endifadded by #18353 are not supported by nasm. (tested with version 2.15.05)This breaks compiling
bf-586.planddes-586.pl.Changing these directives to
%ifdefand%endifseems to be able to get nasm to compile but not sure if this acheives the original desired effect for #18353.