-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
Closed
prchander/openssl
#3Labels
triaged: bugThe issue/pr is/fixes a bugThe issue/pr is/fixes a bug
Milestone
Description
This code does not work on 32 bit big endian machines:
openssl/test/ossl_test_endian.h
Lines 13 to 20 in 9a7319b
| # define DECLARE_IS_ENDIAN \ | |
| const union { \ | |
| long one; \ | |
| char little; \ | |
| } ossl_is_endian = { 1 } | |
| # define IS_LITTLE_ENDIAN (ossl_is_endian.little != 0) | |
| # define IS_BIG_ENDIAN (ossl_is_endian.little == 0) |
I think it just needs to be changed to an int. But I wonder if we have other code like that that uses a long instead of an int. Maybe all that code should use that macro.
gcc also has built in macro's for that, I suggest we use that by default instead.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
triaged: bugThe issue/pr is/fixes a bugThe issue/pr is/fixes a bug