evp_pkey_provided_test fails randomly sometimes #12054
Assignees
Labels
triaged: bug
The issue/pr is/fixes a bug
Comments
|
This is really a generic problem. The test programs should really treat any output that isn't TAP specific as commentary, i.e. ensure that it's prefixed with a |
levitte
added a commit
to levitte/openssl
that referenced
this issue
Jun 5, 2020
Output that's supposed to be understood by a TAP parser gets its own BIOs (|tap_out| and |tap_err|), and is only used internally within testutils. |bio_out| and |bio_err| is now only used for output that shouldn't be parsed by the TAP parser, and all output written to those BIOs are therefore always made to look like comments (it gets prefixed with "# "). Indentation and prefixing with "# " is reworked to use BIO_f_prefix(), which allows us to throw away the internal BIO_f_tap(). The indentation level is now adjusted via a special function. Fixes openssl#12054
levitte
added a commit
to levitte/openssl
that referenced
this issue
Jun 5, 2020
openssl-machine
pushed a commit
that referenced
this issue
Jun 6, 2020
Fixes #12054 Reviewed-by: Matt Caswell <[email protected]> (Merged from #12057)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The evp_pkey_provided_test randomly fails sometimes. It occurs because it dumps PEM files to stdout. If those PEM files happen to contain a line that starts with the text "ok" then it confuses the test harness and the test fails.
Example failing build:
https://travis-ci.org/github/openssl/openssl/jobs/694280520
The text was updated successfully, but these errors were encountered: