added conditional SystemD support for notify#251
Closed
expeditioneer wants to merge 1 commit intoopenssh:masterfrom
expeditioneer:systemd
Closed
added conditional SystemD support for notify#251expeditioneer wants to merge 1 commit intoopenssh:masterfrom expeditioneer:systemd
expeditioneer wants to merge 1 commit intoopenssh:masterfrom
expeditioneer:systemd
Conversation
elarsen-meazure
suggested changes
Apr 20, 2022
configure.ac
Outdated
| SYSTEMD_CFLAGS=`$PKGCONFIG --cflags libsystemd` | ||
| SYSTEMD_LIBS=`$PKGCONFIG --libs libsystemd` | ||
| CPPFLAGS="$CPPFLAGS $SYSTEMD_CFLAGS" | ||
| + SSHDLIBS="$SSHDLIBS $SYSTEMD_LIBS" |
There was a problem hiding this comment.
Suggested change
| + SSHDLIBS="$SSHDLIBS $SYSTEMD_LIBS" | |
| SSHDLIBS="$SSHDLIBS $SYSTEMD_LIBS" |
I had to remove this superfluous + character to get the SSHDLIBS popluted correctly.
based on patch of Jakub Jelen <[email protected]>
|
hello,@expeditioneer, i tested openssh-9.4p1 centos 7,cann't work,if you hava time,can make a test ? |
Contributor
|
We're not interested in taking a dependency on libsystemd, see https://bugzilla.mindrot.org/show_bug.cgi?id=2641 for the approach we are likely to take. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds SystemD notify support.
Based on patch of Jakub Jelen [email protected] from RedHat / CentOS packaging.