Enhance license handling #4223
Merged
Enhance license handling #4223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
BudsieBuds
commented
Apr 19, 2025
BudsieBuds
commented
- Implement license auto-updates to ensure information is always current
- Consolidate all NPM licenses into a single file for easier viewing
- Render license text in a monospace font to enhance clarity and formatting consistency
- Eliminate the outdated Bower license generation code
- automate license updates - license text rendered in monospace font - removed old bower license generation code
jekkos
reviewed
Apr 19, 2025
| } elseif ($fileinfo->getBasename() == 'bower.LICENSES') { | ||
| // set a flag to indicate that the JS Plugin bower.LICENSES file is available and needs to be attached at the end | ||
| $bower = true; | ||
| } elseif ($fileinfo->getBasename() == 'composer.LICENSES') { |
Member
There was a problem hiding this comment.
this code could be simplified a bit, quite a couple of branches to check very sim!ilar things.
Member
Author
There was a problem hiding this comment.
Yeah, my PHP skills are not the greatest. It's worth taking another look at in the future.
Member
|
Very nice improvement @BudsieBuds ! the licenses rendering looks way better now. Thanks for taking this on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.